Page MenuHomePhabricator

Update service-runner logger to support any missing functionality provided by Parsoid's logger
Closed, ResolvedPublic

Description

Parsoid migrated to service-runner but is continuing to use its own logger. Investigate logging functionaliity that needs to be added to service-runner and update it accordingly.

Event Timeline

ssastry triaged this task as Medium priority.Jul 26 2016, 3:41 PM

@ssastry Is anything needed to be done here still or you've solved it on Parsoid side?

There's still some functionality missing, like log sampling,
https://github.com/wikimedia/mediawiki-services-parsoid-deploy/blob/master/conf/wmf/localsettings.js#L31-L39

But, in T141370#2581038, we're using service-runner's logger as a backend to Parsoid's logger, which may obviate the need to upstream that functionality afterall.

@Pchelolo Did you see my question in T141370#2496235?

Log sampling is available in service-runner, cf the example config in the README.

@Pchelolo Did you see my question in T141370#2496235?

It should be pretty straightforward to expose constructing a service-runner Logger from the config.

Arlolra claimed this task.

Log sampling is available in service-runner

Oho! I missed that, thanks.

Ok, let's consider this done.