Parsoid migrated to service-runner but is continuing to use its own logger. Investigate logging functionaliity that needs to be added to service-runner and update it accordingly.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
There's still some functionality missing, like log sampling,
https://github.com/wikimedia/mediawiki-services-parsoid-deploy/blob/master/conf/wmf/localsettings.js#L31-L39
But, in T141370#2581038, we're using service-runner's logger as a backend to Parsoid's logger, which may obviate the need to upstream that functionality afterall.
@Pchelolo Did you see my question in T141370#2496235?
Comment Actions
Log sampling is available in service-runner, cf the example config in the README.
@Pchelolo Did you see my question in T141370#2496235?
It should be pretty straightforward to expose constructing a service-runner Logger from the config.
Comment Actions
Log sampling is available in service-runner
Oho! I missed that, thanks.
Ok, let's consider this done.