The release notes are at
It fixes a few things.
The biggest fix for us is the diff. Since long lines can now be line wrapped through a pref setting. It improves diffs since sometimes the diff line was cut off if it was too long.
Next is T146350: Update gerrit to 2.13.3
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T141329 Patchsets created through web interface attributed to the wrong user | |||
| Resolved | • demon | T144565 Gerrit's new side-by-side diff screen sometimes cuts off the last few characters of a line | |||
| Resolved | • demon | T146260 Gerrit ssh command failing on new repositories, causing zuul to not run against a change | |||
| Resolved | • demon | T148876 Submitting a patch through the web editor on someone elses patch can result in you being able to run the same tests as that owner | |||
| Resolved | • demon | T143089 Update gerrit to 2.12.5 |
@demon gerrit 2.12.4 has been released now.
Release notes
https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.12.4.html
War
https://www.gerritcodereview.com/download/gerrit-2.12.4.war
Can we upgrade to it please?
This update may have performance improvements when we upgrade. But only for the dashboard :)
I think we should not go with gerrit 2.12.4 but instead go with 2.12.5 when released. Since there Is a very bad bug that prevents any new emails from being processed which is fixed in gerrit 2.12.5.
Changing to high due to a recent finding we found, and to match the priority we given that task too.
Change 317654 had a related patch set uploaded (by Chad):
gerrit (2.12.5-wmf.1) jessie-wikimedia; urgency=low
Change 317654 merged by Muehlenhoff:
gerrit (2.12.5-wmf.1) jessie-wikimedia; urgency=low
This task is about 2.12.5. Please do not change the scope of a task without arguments why.
@Aklapper well 2.12.6 was just released so there's no point in upgrading to 2.12.5 if there's 2.12.6.
But we could upgrade to 2.12.5 and then to 2.12.6 since we built 2.12.5 already just need to upgrade gerrit.
That statement is too vague to be correct: Whether there is "no point" or not highly depends on the content of the ChangeLog.
See my previous comment: "Please do not change the scope of a task without arguments why."
Meh, we've already got 2.12.5 packaged, so might as well install & upgrade. I'm not seeing anything super interesting from 2.12.6's release notes that's pressing an upgrade...
Tbh, I'd rather invest the time in moving to 2.13.x at this point so we can get the schema changes behind us.
Mentioned in SAL (#wikimedia-operations) [2016-11-15T18:24:08Z] <ostriches> gerrit: bringing down for a minute or two for quick point upgrade, T143089