Page MenuHomePhabricator
Create Task
Maniphest T143161

Catchable fatal error: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php on line 730
Closed, ResolvedPublic
Actions

Description

When attempting to chunked-upload a file using the API, I get the following error:

Catchable fatal error:  Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given in /var/www/html/w/extensions/AbuseFilter/AbuseFilter.hooks.php on line 730

The easiest way to reproduce is to try uploading a file bigger than 5 MB using the UploadWizard.

Details

SubjectRepoBranchLines +/-
Do not call the 'UploadStashFile' hook for partially uploaded filesmediawiki/corewmf/1.28.0-wmf.15+15 -10
Do not call the 'UploadStashFile' hook for partially uploaded filesmediawiki/coremaster+15 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Aug 16 2016, 9:51 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 16 2016, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex claimed this task.Aug 16 2016, 9:53 PM
matmarex triaged this task as Unbreak Now! priority.

This is a regression from f2e05b105b39b9b683542bce0f966ecf7fcd9084+2ee27d9a4de163dc3a2b752823a04f5338005627.

Restricted Application added subscribers: Luke081515, TerraCodes, Matanya. · View Herald TranscriptAug 16 2016, 9:53 PM
Jdforrester-WMF added a parent task: T140971: MW-1.28.0-wmf.15 deployment blockers.Aug 16 2016, 9:58 PM
Jdforrester-WMF subscribed.
greg subscribed.Aug 16 2016, 10:39 PM
gerritbot subscribed.Aug 16 2016, 11:40 PM

Change 305155 had a related patch set uploaded (by Bartosz Dziewoński):
Do not call the 'UploadStashFile' hook for partially uploaded files

https://gerrit.wikimedia.org/r/305155

gerritbot added a project: Patch-For-Review.Aug 16 2016, 11:40 PM
gerritbot added a comment.Aug 17 2016, 12:44 AM

Change 305155 merged by jenkins-bot:
Do not call the 'UploadStashFile' hook for partially uploaded files

https://gerrit.wikimedia.org/r/305155

gerritbot added a comment.Aug 17 2016, 12:55 AM

Change 305162 had a related patch set uploaded (by Jforrester):
Do not call the 'UploadStashFile' hook for partially uploaded files

https://gerrit.wikimedia.org/r/305162

gerritbot added a comment.Aug 17 2016, 3:11 PM

Change 305162 merged by jenkins-bot:
Do not call the 'UploadStashFile' hook for partially uploaded files

https://gerrit.wikimedia.org/r/305162

Stashbot subscribed.Aug 17 2016, 3:27 PM

Mentioned in SAL [2016-08-17T15:27:29Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.15/includes/upload/UploadBase.php: SWAT: [[gerrit:305162|Do not call the "UploadStashFile" hook for partially uploaded files (T143161)]] PART I (duration: 00m 53s)

Stashbot added a comment.Aug 17 2016, 3:29 PM

Mentioned in SAL [2016-08-17T15:29:08Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.15/includes/api/ApiUpload.php: SWAT: [[gerrit:305162|Do not call the "UploadStashFile" hook for partially uploaded files (T143161)]] PART II (duration: 00m 50s)

greg added a comment.Aug 17 2016, 4:57 PM

So, are we good now after the morning SWAT?

Jdforrester-WMF closed this task as Resolved.Aug 17 2016, 5:19 PM

Sorry, yes.

greg added a comment.Aug 17 2016, 5:22 PM

No apologies needed, thanks, all :)

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits