Data table of Graph cannot take negative values of x & y.
Open, LowPublic
Actions

Assigned To

None

Authored By

	Tanveer07
	Aug 26 2016, 6:42 AM

Description

Steps to reproduce:

Open VE
Click on Insert --> Graph
Attempt to insert negative values on data table in 'Data' mode

Observation:
The cursor just shifts to the end of the number and there is no way a negative sign can be entered before the number.

Note:
User can however enter negative parameters using 'Raw data' mode instead.

Video given below:

Data table cannot accept negative inputs.mp46 MBDownload

Details

	Subject	Repo	Branch	Lines +/-
	Fix input validation of Graph dialog to accept negative numbers	mediawiki/extensions/Graph	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T143978: Incorrect line graph plot appearing for negative values entered in 'Raw data' mode.

Event Timeline

Tanveer07 created this task.Aug 26 2016, 6:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2016, 6:42 AM

Tanveer07 updated the task description. (Show Details)Aug 26 2016, 6:51 AM

Ryasmeen added a project: MediaWiki-extensions-Graph.Aug 26 2016, 8:51 PM

Ryasmeen added a project: Discovery-ARCHIVED.Aug 31 2016, 12:19 AM

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Sep 6 2016, 7:14 PM

I see slightly different behavior from my end. I can insert negative values and it is letting me enter negative sign but when I reopen the dialog, they all get converted to the default values for Y.
This looks like a really broken feature from a VE user's perspective because of this. Would be great to get a feedback on this.

Ryasmeen added a subscriber: Yurik.Nov 21 2016, 10:53 PM

TheDJ moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.Jan 20 2022, 3:23 PM

Change 756127 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Graph@master] Fix input validation of Graph dialog to accept negative numbers

https://gerrit.wikimedia.org/r/756127

gerritbot added a project: Patch-For-Review.Jan 22 2022, 8:03 PM

TheDJ claimed this task.Jan 22 2022, 8:03 PM

TheDJ added a project: User-TheDJ.

TheDJ mentioned this in T143978: Incorrect line graph plot appearing for negative values entered in 'Raw data' mode..Jan 22 2022, 8:15 PM

Aklapper merged a task: T143978: Incorrect line graph plot appearing for negative values entered in 'Raw data' mode..Feb 9 2023, 12:14 PM

Aklapper added a subscriber: TheDJ.

Cant reproduce it, fixed? @TheDJ