Page MenuHomePhabricator

On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce

  1. Open VE
  2. Add an image
  3. Save the page
  4. Reopen VE

Observed Result:

Images are not appearing after reopening VE, shows red link for it. However, it appears in Read mode and while adding it first time.

Screen Shot 2016-09-06 at 6.35.36 PM.png (671×1 px, 132 KB)

Event Timeline

Jdforrester-WMF renamed this task from Images are not appearing inside VE, after reopening the page to On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE.Sep 8 2016, 1:06 AM

Maybe someone is doing something special in Beta Cluster? It's not happening in production.

I think the Special:FilePath link is coming in from Parsoid, but the code (in wt2html/tt/LinkHandler.js) hasn't changed in months…

Try refreshing the content in RESTBase or let us ask Services folks to purge content in RESTBase. For a little while, Parsoid was failing on all mediawiki API requests once beta cluster moved to https only. I fixed that this morning ( https://gerrit.wikimedia.org/r/#/c/309001/ ). @GWicke, @mobrovac ... could you do the needful please?

So, the cause will be https://gerrit.wikimedia.org/r/#/c/307762/

krenair@deployment-tin:~$ curl -X POST http://deployment-parsoid09:8000/en.wikipedia.beta.wmflabs.org/v3/transform/wikitext/to/html/Main_Page --data "wikitext=[[File:Ophelia - Hybrid Tea.jpg]]" 2>/dev/null | grep -o mw:Error
mw:Error

I did some more digging and found that although @ssastry made https://gerrit.wikimedia.org/r/#/c/309001/, he didn't actually deploy it:

krenair@deployment-tin:/srv/deployment/parsoid/deploy$ git log --oneline -1
c4cb920 Bump src to 7863e6ad + update node modules

So I ran git fetch origin, git merge origin/master, ssh deployment-parsoid09.deployment-prep.eqiad.wmflabs (to get the known host entry), sudo usermod -a -G deploy-service krenair, scap deploy

And now we can deal with the RB cache

Mentioned in SAL [2016-09-08T02:25:53Z] <Krenair> deployed the latest version of mediawiki/services/parsoid/deploy.git to get https://gerrit.wikimedia.org/r/#/c/309001/ see T144884

I did some more digging and found that although @ssastry made https://gerrit.wikimedia.org/r/#/c/309001/, he didn't actually deploy it:

Yikes ... sorry. Thanks for fixing this!

Ryasmeen added a project: Verified.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.