Page MenuHomePhabricator
Create Task
Maniphest T145344

Unable to undo or edit previous revision to undo contentmodel change with intermediate edit
Open, MediumPublic
Actions

Description

Posted originally at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals) :
Scenario:

User A writes the last good revision to page "Foo".
User B maliciously changes the content model of "Foo" from wikitext to CSS.
User C edits the page in good faith.
User D would like to revert to User A's revision without knowledge of Special:ChangeContentModel. (as not required by the undo/rollback cases tested so far)

Bug: User D is unable to do so.

A page set up with this scenario is at https://test2.wikipedia.org/wiki/Law3 (https://test2.wikipedia.org/w/index.php?title=Law3&oldid=296990)

Details

SubjectRepoBranchLines +/-
Add a change tag for edits that change the content model of a pagemediawiki/coremaster+33 -13
Customize query in gerrit

Related Objects

Event Timeline

andymw created this task.Sep 11 2016, 10:29 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptSep 11 2016, 10:29 PM
andymw added a comment.Sep 11 2016, 10:39 PM

Believe not supporting editing a previous revision of in a different contentmodel is problematic and probable on high-traffic mainspace pages. Twinkle's revert to previous revision would break here too, as far as I know.
@Legoktm remarked at VPR that a potential mitigation is a "change tag that indicates the edit changed the content model of the page, which would then link to documentation about changing content models".

Legoktm added a comment.Sep 11 2016, 10:40 PM

Rollback of course doesn't work, because rollback can only be used on edits by the same user. So I'll remove that from the summary.

Legoktm renamed this task from Unable to undo, rollback, or edit previous revision to undo contentmodel change with intermediate edit to Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.Sep 11 2016, 10:40 PM
Legoktm edited projects, added MediaWiki-Page-editing; removed Community-consensus-needed, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release-notes, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)).
• MZMcBride added a comment.Sep 12 2016, 4:56 AM

Page moves have a similar issue, right?

andymw added a comment.Sep 12 2016, 1:46 PM

@MZMcBride Similar issue in that undo doesn't work when there's an intermediate edit... but I'd say that in terms of usability, it's not as disruptive, and not being able to undo page moves is well-known. Users are given a "Move" option in the tabs at the top that takes users directly to Special:MovePage, whereas "Change content model" is not an option given (and probably shouldn't be).

I claim that content model changes have the potential to be more disruptive precisely because the option is not given in the UI, and most folks don't know about Special:ChangeContentModel.

andymw added a comment.EditedSep 12 2016, 6:17 PM

Comment: if it's decided that edit-previous-revision cross-contentmodel is to be supported, then non-autoconfirmed users (or whatever the scope of editcontentmodel is) should not be able to edit a revision with a different contentmodel because they don't have the permission.

(Don't know how relevant this is, but today, an IP (or non-autoconfirmed) looks like it can revert to a previous revision that has the same contentmodel as the current even when some intermediate revisions are in a different contentmodel. Looks reasonable)

gerritbot added a comment.Sep 13 2016, 7:11 AM

Change 310224 had a related patch set uploaded (by Legoktm):
Add a change tag for edits that change the content model of a page

https://gerrit.wikimedia.org/r/310224

gerritbot added a project: Patch-For-Review.Sep 13 2016, 7:11 AM
gerritbot added a comment.Sep 13 2016, 11:42 AM

Change 310224 merged by jenkins-bot:
Add a change tag for edits that change the content model of a page

https://gerrit.wikimedia.org/r/310224

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release-notes.Sep 13 2016, 12:00 PM
• RobLa-WMF mentioned this in T85847: Grant editcontentmodel right to all logged in users.Sep 13 2016, 12:35 PM
Legoktm added a comment.Sep 15 2016, 9:16 AM

So we now have a change tag in the page history, which should alleviate the discovery problem of finding Special:ChangeContentModel. I would propose that we leave this bug open, but remove it as a blocker of granting editcontentmodel.

andymw added a comment.Sep 15 2016, 3:02 PM

@Legoktm I'm a bit new at this, but as the bug filer, solution is fine by me for now. (wonder if tech ambassadors wanted to add anything) Makes sense to continue to track this

Legoktm removed a parent task: T85847: Grant editcontentmodel right to all logged in users.Sep 16 2016, 2:27 AM
BethNaught subscribed.Jan 3 2017, 8:27 PM
Umherirrender removed a project: Patch-For-Review.Apr 2 2022, 8:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL