Page MenuHomePhabricator
Create Task
Maniphest T145493

Some buttons in mobile interface don't indicate clickable target with pointer
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

mediawiki-ui doesn't set cursor:pointer by default for mw-ui-icon and mw-ui-button and mw-ui-checkbox. It should.

  1. The watch star (see related T142527)
  2. The close button when you select the search field.
  3. The mw-ui-checkboxes in the preferences (also mw-ui)...

# the indicator for the amount of notifications (notification-count). (the button itself is correct )~

Acceptance criteria

  • Update mw-ui-checkbox element inside MediaWiki core to show a cursor: pointer;
  • .watch-this-article in Minerva to show a cursor pointer
  • .cancel in Minerva should show a cursor pointer

Details

SubjectRepoBranchLines +/-
Partially undo I88c70famediawiki/extensions/MobileFrontendmaster+0 -1
Make sure that all buttons in the actions area have pointermediawiki/skins/MinervaNeuemaster+4 -0
Make sure watchlist and overlay buttons have pointer cursormediawiki/extensions/MobileFrontendmaster+5 -0
Make sure that mw-ui checkboxes have pointer cursormediawiki/coremaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Sep 13 2016, 8:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2016, 8:43 AM
Jdlrobson updated the task description. (Show Details)Sep 13 2016, 5:16 PM
MBinder_WMF added a project: Web-Team-Backlog.Sep 13 2016, 5:18 PM
• Jhernandez triaged this task as Low priority.Sep 14 2016, 4:28 PM
• Jhernandez moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
• Jhernandez added a project: good first task.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 14 2016, 4:28 PM
Ksrr18 claimed this task.Oct 2 2016, 1:05 PM
Ksrr18 removed Ksrr18 as the assignee of this task.Oct 2 2016, 1:10 PM
Ksrr18 subscribed.
TheDJ mentioned this in T88449: Buttons differ between OOjs UI and mediawiki UI (tracking).Oct 4 2016, 4:27 PM
• jhobs mentioned this in T146434: SchemaPopupsSamplingRate config variable is badly named.Dec 7 2016, 6:29 PM
McIntireEvan claimed this task.Dec 7 2016, 10:32 PM
Jdlrobson subscribed.Dec 15 2016, 7:04 PM

@McIntireEvan any updates on this task?

Jdlrobson added projects: patch-welcome, UI-Standardization.May 26 2017, 6:25 PM
Jdlrobson removed McIntireEvan as the assignee of this task.May 26 2017, 6:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: McIntireEvan.
Jdlrobson added a subscriber: Volker_E.

@Volker_E is this something best taken care of by you?

Volker_E added a comment.May 27 2017, 2:29 PM

@Jdlrobson Sure, I'll do!

Volker_E claimed this task.May 27 2017, 2:29 PM
Jdlrobson added a comment.Jun 29 2017, 11:44 PM

Ping @Volker_E ... my updates a month later. I can review patch!

Jdlrobson removed Volker_E as the assignee of this task.Aug 1 2017, 9:12 PM
Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson added a project: Design (RW-Design-Debt).
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.

This is incredibly easy so why don't we just make this happen...

Jdlrobson updated the task description. (Show Details)Aug 8 2017, 4:18 PM
Jdlrobson set the point value for this task to 2.
Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Aug 9 2017, 1:46 PM
Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.
Jdlrobson edited projects, added Africa-Wikimedia-Developers; removed Readers-Web-Kanbanana-Board-Old.Aug 9 2017, 2:16 PM

I can mentor this task.

gerritbot subscribed.Aug 9 2017, 5:07 PM

Change 370849 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/MobileFrontend@master] Make sure watchlist and overlay buttons have pointer cursor

https://gerrit.wikimedia.org/r/370849

gerritbot added a project: Patch-For-Review.Aug 9 2017, 5:07 PM

Change 370837 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] Make sure that mw-ui checkboxes have pointer cursor

https://gerrit.wikimedia.org/r/370837

gerritbot added a comment.Aug 9 2017, 5:19 PM

Change 370837 merged by jenkins-bot:
[mediawiki/core@master] Make sure that mw-ui checkboxes have pointer cursor

https://gerrit.wikimedia.org/r/370837

gerritbot added a comment.Aug 9 2017, 5:20 PM

Change 370849 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Make sure watchlist and overlay buttons have pointer cursor

https://gerrit.wikimedia.org/r/370849

Jdlrobson edited projects, added Readers-Web-Kanbanana-Board-Old, Unplanned-Sprint-Work; removed Patch-For-Review, Africa-Wikimedia-Developers.Aug 9 2017, 5:56 PM

Patches have been written by TheDJ and merged so let's sign off on this

Jdlrobson moved this task from To Do to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Aug 9 2017, 5:56 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 9 2017, 6:00 PM
Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Aug 9 2017, 8:42 PM

Looks like the watchstar still doesn't have a pointer on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page - should be an easy fix.

gerritbot added a comment.Aug 10 2017, 1:27 PM

Change 371025 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/MobileFrontend@master] Partially undo I88c70fa

https://gerrit.wikimedia.org/r/371025

gerritbot added a project: Patch-For-Review.Aug 10 2017, 1:27 PM
gerritbot added a comment.Aug 10 2017, 1:32 PM

Change 371028 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/skins/MinervaNeue@master] Make sure that all buttons in the actions area have pointer

https://gerrit.wikimedia.org/r/371028

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Aug 10 2017, 2:47 PM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.
gerritbot added a comment.Aug 10 2017, 2:53 PM

Change 371028 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Make sure that all buttons in the actions area have pointer

https://gerrit.wikimedia.org/r/371028

gerritbot added a comment.Aug 10 2017, 3:13 PM

Change 371025 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Partially undo I88c70fa

https://gerrit.wikimedia.org/r/371025

Jdlrobson closed this task as Resolved.Aug 10 2017, 4:32 PM
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson updated the task description. (Show Details)

Tested on beta cluster. See cursor for overlay close icon (editor/search) as well as watch, hamburger, language button (only when enabled) and notifications icon. LGTM

Jdlrobson mentioned this in T197105: [Bug] Gallery next / previous buttons use default arrow instead of pointer (hand) cursor.Jun 14 2018, 4:42 PM
Jdlrobson mentioned this in T205321: [Bug] Search icon has no visual indication that it's a button on small screens.Sep 24 2018, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL