Page MenuHomePhabricator

Some buttons in mobile interface don't indicate clickable target with pointer
Closed, ResolvedPublic2 Estimated Story Points

Description

mediawiki-ui doesn't set cursor:pointer by default for mw-ui-icon and mw-ui-button and mw-ui-checkbox. It should.

  1. The watch star (see related T142527)
  2. The close button when you select the search field.
  3. The mw-ui-checkboxes in the preferences (also mw-ui)...

# the indicator for the amount of notifications (notification-count). (the button itself is correct )~

Acceptance criteria

  • Update mw-ui-checkbox element inside MediaWiki core to show a cursor: pointer;
  • .watch-this-article in Minerva to show a cursor pointer
  • .cancel in Minerva should show a cursor pointer

Event Timeline

Jhernandez moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
Jhernandez added a project: good first task.
Ksrr18 removed Ksrr18 as the assignee of this task.Oct 2 2016, 1:10 PM
Ksrr18 added a subscriber: Ksrr18.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: McIntireEvan.
Jdlrobson added a subscriber: Volker_E.

@Volker_E is this something best taken care of by you?

Ping @Volker_E ... my updates a month later. I can review patch!

Jdlrobson raised the priority of this task from Low to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Triaged but Future to Upcoming on the Readers-Web-Backlog board.

This is incredibly easy so why don't we just make this happen...

Jdlrobson set the point value for this task to 2.

Change 370849 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/MobileFrontend@master] Make sure watchlist and overlay buttons have pointer cursor

https://gerrit.wikimedia.org/r/370849

Change 370837 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] Make sure that mw-ui checkboxes have pointer cursor

https://gerrit.wikimedia.org/r/370837

Change 370837 merged by jenkins-bot:
[mediawiki/core@master] Make sure that mw-ui checkboxes have pointer cursor

https://gerrit.wikimedia.org/r/370837

Change 370849 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Make sure watchlist and overlay buttons have pointer cursor

https://gerrit.wikimedia.org/r/370849

Patches have been written by TheDJ and merged so let's sign off on this

Change 371025 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/MobileFrontend@master] Partially undo I88c70fa

https://gerrit.wikimedia.org/r/371025

Change 371028 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/skins/MinervaNeue@master] Make sure that all buttons in the actions area have pointer

https://gerrit.wikimedia.org/r/371028

Change 371028 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Make sure that all buttons in the actions area have pointer

https://gerrit.wikimedia.org/r/371028

Change 371025 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Partially undo I88c70fa

https://gerrit.wikimedia.org/r/371025

Jdlrobson removed a project: Patch-For-Review.
Jdlrobson updated the task description. (Show Details)

Tested on beta cluster. See cursor for overlay close icon (editor/search) as well as watch, hamburger, language button (only when enabled) and notifications icon. LGTM