T144865: Add pageview stats to the action API would add an abstract pageview service (see T144865#2633788) after which it would be trivial to make WikimediaPageViewInfo non-Wikimedia-specific, so after discussion with @Legoktm I'd like to use that extension for the API module, and rename it to make clear it can be used on other wikis.
Extension renames suck, but this one has not been deployed anywhere yet, and is WMF-only, so it should not be that bad.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T40450 Reimplement MediaWiki's info action (tracking) | ||
| Declined | None | T43326 Incorporate analytics into MediaWiki's info action | |||
| Resolved | Tgr | T43327 Add page views graph(s) to MediaWiki's info action for Wikimedia wikis | |||
| Resolved | Tgr | T125917 Deploy the PageViewInfo extension to production | |||
| Resolved | Tgr | T129602 Deploy WikimediaPageViewInfo extension to beta cluster | |||
| Resolved | Tgr | T144865 Add pageview stats to the action API | |||
| Resolved | Reedy | T148775 Rename WikimediaPageViewInfo extension to PageViewInfo | |||
| Resolved | Peachey88 | T150227 Rename WikimediaPageviewInfo Phabricator project/tag to PageViewInfo |
What's involved in renaming an extension? Creating a new Gerrit repository and importing the Git history?
Yep, request a new repo and history can be copied over. Then we'll mark the old one as hidden/read-only as appropriate.
Would be great if someone did! Just don't delete the old repo yet, there are a bunch of pending changes in gerrit.
Mentioned in SAL (#wikimedia-releng) [2016-11-04T13:20:03Z] <hashar> gerrit: created mediawiki/extensions/PageViewInfo.git and renamed user group extension-WikimediaPageViewInfo to extension-PageViewInfo T148775
[13:59:44] <grrrit-wm> (PS1) Reedy: Fix .gitreview for rename [extensions/PageViewInfo] - https://gerrit.wikimedia.org/r/319848
[14:00:06] <grrrit-wm> (PS1) Reedy: wmpvi -> pvi for rename [extensions/PageViewInfo] - https://gerrit.wikimedia.org/r/319849
[14:10:02] <grrrit-wm> (PS1) Reedy: Rename WikimediaPageViewInfo -> PageViewInfo [translatewiki] - https://gerrit.wikimedia.org/r/319853
Extension and branches are all pushed to the new extension name
Blank github repo created, which has caused the imports there
Still missing on Phab, dunno if that requires further poking
Will add it to the extensions all in one meta repo thing when my repos finish updating again
Then it's just cherry picking the commits that are WIP onto the new repo (this works nicely if you use the generated cherry pick links).. Might be easier to rebase them on the old repo first, and then fix them up on the new repo post cherry pick too
Awesome, thank you to everyone who's helped so far!
Lego can do this at some point, if someone else doesn't beat him to it. I think the repo has to be added to Diffusion manually by a Phabricator admin.
Then it's just cherry picking the commits that are WIP onto the new repo (this works nicely if you use the generated cherry pick links).. Might be easier to rebase them on the old repo first, and then fix them up on the new repo post cherry pick too
These, I guess: https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/WikimediaPageViewInfo+status:open? Seems pretty straightforward.
Change 319853 had a related patch set uploaded (by Reedy):
Rename WikimediaPageViewInfo -> PageViewInfo
Change 320174 had a related patch set uploaded (by Gergő Tisza):
Rename WikimediaPageViewInfo to PageViewInfo
I see that @Tgr beat me to the wiki page move: https://www.mediawiki.org/wiki/Extension:PageViewInfo.
Anything else need doing at this point?
Nope. WIP patches have been moved over https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/PageViewInfo