Page MenuHomePhabricator
Create Task
Maniphest T148827

Implement Lemma in Lexeme
Closed, ResolvedPublic
Actions

Description

Per https://www.wikidata.org/wiki/Wikidata:Wiktionary/Development/Proposals/2015-05

We talked about it with @WMDE-leszek and we think: Lemma should be a Term.

  • Add provider interface
  • Add to entity as an attribute and add getter and setter
  • Add to content as part of isstub
  • Add to Special:NewEntity
  • Consider in equals() method
  • Consider in __clone() method
  • Consider in isEmpty() method
  • Add to serializer
  • Add to deserializer
  • Add to patcher
  • Add to differ
  • Add support in EntityView
  • Add to RDF mapping (not currently pluggable!)
  • Add Validation (not currently pluggable)
  • Add ChangeOp for updating (must work with wbeditentity)
  • Add handling (or suppression) to EntityChangeFactory (not currently pluggable)

Details

SubjectRepoBranchLines +/-
Make Lemma work with LexemeViewmediawiki/extensions/WikibaseLexememaster+129 -25
Make Lemma a TermList and rename it to Lemmata (plural)mediawiki/extensions/WikibaseLexememaster+118 -114
Make Differ work with Lemmamediawiki/extensions/WikibaseLexememaster+88 -6
Add lemma to Lexeme modelmediawiki/extensions/WikibaseLexememaster+138 -19
First pass on Lemmamediawiki/extensions/WikibaseLexememaster+64 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Oct 21 2016, 11:08 AM
Restricted Application added projects: Wikidata, User-Ladsgroup. · View Herald TranscriptOct 21 2016, 11:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jakob_WMDE subscribed.Oct 21 2016, 1:35 PM
Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Oct 22 2016, 7:00 AM
WMDE-leszek triaged this task as Medium priority.Oct 24 2016, 10:50 AM
WMDE-leszek added a parent task: T148139: Implement a base version of the Lexeme Entity type.
Ladsgroup renamed this task from Implement Lemma, Lexical category and Language to Implement Lemma in Lexeme.Oct 29 2016, 9:11 PM
Ladsgroup updated the task description. (Show Details)
Ladsgroup moved this task from doing to proposed on the WMDE-TLA-Team board.
daniel moved this task from proposed to accepted on the WMDE-TLA-Team board.Nov 1 2016, 1:38 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Nov 10 2016, 10:35 PM
Jakob_WMDE moved this task from accepted to doing on the WMDE-TLA-Team board.Nov 15 2016, 12:54 PM
gerritbot subscribed.Nov 17 2016, 10:20 AM

Change 322073 had a related patch set uploaded (by Ladsgroup):
First pass on Lemma

https://gerrit.wikimedia.org/r/322073

gerritbot added a project: Patch-For-Review.Nov 17 2016, 10:20 AM
Ladsgroup mentioned this in rEWLEcad830b66f65: First pass on Lemma.Nov 17 2016, 10:26 AM
Ladsgroup mentioned this in rEWLE61ffb2f88b79: First pass on Lemma.Nov 17 2016, 10:33 AM
Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Nov 17 2016, 10:48 AM
Ladsgroup edited projects, added Wikidata-Former-Sprint-Board; removed WMDE-TLA-Team.Nov 18 2016, 10:27 AM
Ladsgroup moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.Nov 18 2016, 10:28 AM
Ladsgroup mentioned this in rEWLE6379fcf4bc0e: First pass on Lemma.Nov 19 2016, 4:32 PM
Ladsgroup mentioned this in rEWLE9be20be3c16e: First pass on Lemma.Nov 19 2016, 4:50 PM
Ladsgroup mentioned this in rEWLE53684cb508dc: First pass on Lemma.Nov 19 2016, 4:55 PM
Ladsgroup mentioned this in rEWLE5de28ba38d77: First pass on Lemma.Nov 21 2016, 9:27 AM
Ladsgroup mentioned this in rEWLE6db6c0da7139: First pass on Lemma.Nov 21 2016, 10:47 AM
Ladsgroup mentioned this in rEWLEbe8efe143551: First pass on Lemma.Nov 21 2016, 11:55 AM
gerritbot added a comment.Nov 21 2016, 12:09 PM

Change 322073 merged by jenkins-bot:
First pass on Lemma

https://gerrit.wikimedia.org/r/322073

Ladsgroup moved this task from Blocked on others to In progress on the User-Ladsgroup board.Nov 21 2016, 4:33 PM
Ladsgroup updated the task description. (Show Details)Nov 22 2016, 3:42 PM
gerritbot added a comment.Nov 23 2016, 8:36 AM

Change 323125 had a related patch set uploaded (by Ladsgroup):
The second pass on Lexeme

https://gerrit.wikimedia.org/r/323125

Ladsgroup mentioned this in rEWLE17cf3482ecdd: The second pass on Lexeme.Nov 23 2016, 8:38 AM
Ladsgroup updated the task description. (Show Details)Nov 23 2016, 9:44 AM
Ladsgroup mentioned this in rEWLE02d386a5cb06: The second pass on Lexeme.Nov 23 2016, 9:45 AM
Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Nov 23 2016, 10:00 AM
Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.
gerritbot added a comment.Nov 23 2016, 12:51 PM

Change 323144 had a related patch set uploaded (by Ladsgroup):
Make Differ work with Lemma

https://gerrit.wikimedia.org/r/323144

Ladsgroup mentioned this in rEWLEe049d81d0c96: Make Differ work with Lemma.Nov 23 2016, 12:53 PM
Ladsgroup mentioned this in rEWLEb10b42034096: Make Differ work with Lemma.Nov 23 2016, 1:13 PM
Ladsgroup mentioned this in rEWLEc1f04df162b2: The second pass on Lexeme.Nov 23 2016, 8:49 PM
Ladsgroup mentioned this in rEWLE67ea5f13b8b8: Make Differ work with Lemma.
daniel mentioned this in rEWLE9a73c6c1a400: Add lemma to Lexeme model.Nov 23 2016, 8:52 PM
Ladsgroup mentioned this in rEWLEc0bb602e46a0: Add lemma to Lexeme model.Nov 24 2016, 11:58 AM
Ladsgroup mentioned this in rEWLE2faa2ef60913: Make Differ work with Lemma.
daniel added a subtask: T151581: Design a more flexible replacement for Fingerprint class.Nov 24 2016, 6:38 PM
daniel subscribed.

It's unclear from the task description whether it is asking for a preliminary implementation (for alpha testing), which can be "faked" using labels, or whether it's asking for a full, proper implementation, including a plugin interface for RDF mappings of labels, etc. I propose to split the task, to make explicit the blockers for alpha vs the decent implementation.

daniel created subtask T151582: Decide whether a Lexeme's lemma is a single Term, or a TermList (multi-variant)..Nov 24 2016, 6:44 PM
Ladsgroup mentioned this in rEWLE1175395994fa: Add lemma to Lexeme model.Nov 25 2016, 5:45 PM
Ladsgroup mentioned this in rEWLE6340012d59e7: Make Differ work with Lemma.
gerritbot added a comment.Nov 28 2016, 3:48 PM

Change 323125 merged by jenkins-bot:
Add lemma to Lexeme model

https://gerrit.wikimedia.org/r/323125

gerritbot added a comment.Nov 28 2016, 3:48 PM

Change 323144 merged by jenkins-bot:
Make Differ work with Lemma

https://gerrit.wikimedia.org/r/323144

Ladsgroup moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Nov 29 2016, 9:54 AM
Ladsgroup updated the task description. (Show Details)Nov 29 2016, 10:52 AM
gerritbot added a comment.Nov 29 2016, 10:52 AM

Change 324116 had a related patch set uploaded (by Ladsgroup):
Make Lemma a TermList and rename it to Lemmata (plural)

https://gerrit.wikimedia.org/r/324116

Ladsgroup mentioned this in rEWLEbea6f6a64e24: Make Lemma a TermList and rename it to Lemmata (plural).Nov 29 2016, 10:53 AM
Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Nov 29 2016, 10:53 AM
Ladsgroup mentioned this in rEWLEa8ae86546922: Make Lemma a TermList and rename it to Lemmata (plural).Nov 29 2016, 11:28 AM
Ladsgroup mentioned this in rEWLE6ea1db5d572a: Make Lemma a TermList and rename it to Lemmata (plural).Nov 29 2016, 1:27 PM
gerritbot added a comment.Nov 29 2016, 2:00 PM

Change 324116 merged by jenkins-bot:
Make Lemma a TermList and rename it to Lemmata (plural)

https://gerrit.wikimedia.org/r/324116

Ladsgroup moved this task from Blocked on others to In progress on the User-Ladsgroup board.Nov 29 2016, 2:00 PM
gerritbot added a comment.Nov 30 2016, 10:50 AM

Change 324400 had a related patch set uploaded (by Ladsgroup):
Make Lemma work with LexemeView

https://gerrit.wikimedia.org/r/324400

Ladsgroup moved this task from In progress to Blocked on others on the User-Ladsgroup board.Nov 30 2016, 10:51 AM
Ladsgroup mentioned this in rEWLE9b000983d56b: Make Lemma work with LexemeView.Nov 30 2016, 10:51 AM
Ladsgroup mentioned this in rEWLE1fcf5e9e2d23: Make Lemma work with LexemeView.Nov 30 2016, 11:59 AM
daniel added a subtask: T152019: Decide whether a Lexeme's lemma can have multiple representations for the same language code..Nov 30 2016, 5:35 PM
daniel closed subtask T151582: Decide whether a Lexeme's lemma is a single Term, or a TermList (multi-variant). as Resolved.Nov 30 2016, 5:43 PM
Ladsgroup mentioned this in rEWLEae44af638b95: Make Lemma work with LexemeView.Dec 1 2016, 10:46 AM
gerritbot added a comment.Dec 1 2016, 2:50 PM

Change 324400 merged by jenkins-bot:
Make Lemma work with LexemeView

https://gerrit.wikimedia.org/r/324400

Ladsgroup updated the task description. (Show Details)Dec 1 2016, 2:52 PM
Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Dec 2 2016, 12:18 PM
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.Dec 5 2016, 3:17 PM
thiemowmde closed this task as Resolved.Jan 3 2017, 1:29 PM
Lydia_Pintscher closed subtask T152019: Decide whether a Lexeme's lemma can have multiple representations for the same language code. as Resolved.Mar 7 2017, 3:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL