Page MenuHomePhabricator
Create Task
Maniphest T149723

Differentiate between <mapframe> and <maplink> page counts in Grafana
Closed, DeclinedPublic
Actions

Description

Instead of batching them together, we should separate them into multiple tracking categories.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Don't store number of maplinks/mapframes as page propsThiemo Kreuz (WMDE)mediawiki/extensions/Kartographermaster+10 -43
refreshLinks.php: allow refreshing by categories, tracking or notMaxSemmediawiki/coremaster+239 -104
Track mapframes and maplinks separatelyMaxSemmediawiki/extensions/Kartographermaster+48 -0
Customize query in gerrit

Related Objects

Event Timeline

Yurik created this task.Nov 1 2016, 6:08 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptNov 1 2016, 6:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Yurik moved this task from All map-related tasks to Analytics on the Maps board.Nov 1 2016, 6:08 PM
Aklapper renamed this task from Diffirentiate between <mapframe> and <maplink> page counts in Grafana to Differentiate between <mapframe> and <maplink> page counts in Grafana.Nov 1 2016, 8:40 PM
Gehel moved this task from Backlog to To-do on the Maps-Sprint board.Nov 2 2016, 7:34 PM
MaxSem claimed this task.Nov 23 2016, 12:21 AM
MaxSem moved this task from To-do to In progress on the Maps-Sprint board.
This comment was removed by MaxSem.
gerritbot subscribed.Nov 23 2016, 10:30 PM

Change 323325 had a related patch set uploaded (by MaxSem):
Track mapframes and maplinks separately

https://gerrit.wikimedia.org/r/323325

gerritbot added a project: Patch-For-Review.Nov 23 2016, 10:30 PM
gerritbot added a comment.Nov 23 2016, 11:53 PM

Change 323325 merged by jenkins-bot:
Track mapframes and maplinks separately

https://gerrit.wikimedia.org/r/323325

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 1:00 AM
gerritbot added a comment.Nov 29 2016, 11:09 PM

Change 324347 had a related patch set uploaded (by MaxSem):
refreshLinks.php: allow refreshing by categories, tracking or not

https://gerrit.wikimedia.org/r/324347

Yurik moved this task from Analytics to Kartographer on the Maps board.Dec 6 2016, 3:31 PM
Yurik edited projects, added: Maps (Kartographer); removed: Maps.
• Deskana subscribed.Jan 20 2017, 6:50 PM

I think this needs to happen; data on this distinction may be very important in the future.

gerritbot added a comment.Jan 26 2017, 3:33 AM

Change 324347 merged by jenkins-bot:
refreshLinks.php: allow refreshing by categories, tracking or not

https://gerrit.wikimedia.org/r/324347

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), MW-1.29-release-notes.Jan 26 2017, 4:00 AM
MaxSem moved this task from In progress to To-do on the Maps-Sprint board.Feb 6 2017, 7:50 PM
MaxSem removed MaxSem as the assignee of this task.May 2 2017, 11:02 PM
Krinkle removed projects: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).May 25 2017, 1:34 PM
Gehel subscribed.Jun 6 2017, 7:29 PM

Looking at graphite (under the key kartographer.pages.*), I still see only a singe metric per wiki, so unless I misunderstand what we planned to do here (and that might well be the case) I think this has not been entirely completed yet.

Gehel added a comment.Jun 6 2017, 7:30 PM

@MaxSem do you know what we actually tried to do with this? Do you know where those new metrics should be?

• debt moved this task from To-do to Stalled/Waiting on the Maps-Sprint board.Jun 6 2017, 7:40 PM
MaxSem added a comment.Jun 6 2017, 7:56 PM

I initially added different tracking categories for mapframe and maplink, but then reverted because with all the analytics requirements, pages would end up with a bunch of silly categories not needed by users. So, this needs to be done from scratch.

• debt moved this task from Stalled/Waiting to Backlog on the Maps-Sprint board.Jun 6 2017, 8:20 PM
• debt removed projects: MW-1.29-release-notes, Patch-For-Review.
• debt subscribed.

Thanks for the info, @MaxSem. Moving to backlog until such time that we can take this up again.

• debt removed a project: Maps-Sprint.Jun 15 2017, 12:38 AM

Moving off the sprint board - the Discovery team won't be able to do this work at this time.

• Jhernandez removed a project: Discovery-ARCHIVED.Jul 10 2018, 4:39 PM
• Mholloway moved this task from Unsorted to General on the Maps (Kartographer) board.Oct 9 2018, 3:55 PM
thiemowmde mentioned this in T437686: Exclude __TOC__ and possibly others from wasting space in page_props table.Sep 11 2026, 10:00 AM
gerritbot added a comment.Sep 11 2026, 10:19 AM

Change #1339668 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Don't store number of maplinks/mapframes as page props

https://gerrit.wikimedia.org/r/1339668

gerritbot added a project: Patch-For-Review.Sep 11 2026, 10:19 AM
Krinkle closed this task as Declined.Mon, Sep 21, 1:56 PM
gerritbot added a comment.Mon, Sep 21, 2:05 PM

Change #1339668 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Don't store number of maplinks/mapframes as page props

https://gerrit.wikimedia.org/r/1339668

Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 21, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits