It's unused, and the one in flowdb on x1 is empty, so instead of giving it a PK we should just drop it.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Delete unused flow_subscription table | mediawiki/extensions/Flow | master | +2 -30 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T18660 Database table cleanup (tracking) | ||
| Resolved | LSobanski | T54921 Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking) | |||
| Resolved | Marostegui | T149936 Drop flow_subscription table |
Event Timeline
Comment Actions
Change 319642 had a related patch set uploaded (by Catrope):
Delete unused flow_subscription table
Comment Actions
Looks good, waiting on code deployment for production deploy- then this or a subticket should be added as a subtask of ticket: T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking)
Comment Actions
The code is deployed now.
- then this or a subticket should be added as a subtask of ticket: T54921: Database tables to be dropped on Wikimedia wikis and other WMF databases (tracking)
Done.
Comment Actions
Those are not considered schema changes for us, at least not for now. We use tracking task T54921 for that. The difference is that these do not "block" anyone.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-04-16T06:20:08Z] <marostegui> Drop table flow_subscription from x1 - T149936
Comment Actions
flow_subscription has been deleted from x1.
It was empty, so no backup is needed. It didn't have any writes since 2015.
This is the structure, for the record:
CREATE TABLE `flow_subscription` ( `subscription_workflow_id` int(10) unsigned NOT NULL, `subscription_user_id` bigint(20) unsigned NOT NULL, `subscription_create_timestamp` varbinary(14) NOT NULL, `subscription_last_updated` varbinary(14) NOT NULL, `subscription_user_wiki` varbinary(64) NOT NULL, UNIQUE KEY `flow_subscription_unique_user_workflow` (`subscription_workflow_id`,`subscription_user_id`,`subscription_user_wiki`), KEY `flow_subscription_lookup` (`subscription_user_id`,`subscription_user_wiki`,`subscription_last_updated`,`subscription_workflow_id ) ENGINE=InnoDB DEFAULT CHARSET=binary
@Catrope let me know about the one in s3 (it has no writes since 2015 either and it is empty)
Comment Actions
Thanks! I will drop this table on Monday - for the sake of not dropping a table on a Friday :-)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-04-23T05:28:54Z] <marostegui> flow_subscription empty table from officewiki - T149936