Page MenuHomePhabricator
Create Task
Maniphest T152258

Aligning FlaggedRevision to WikimediaUI color palette received negative feedback
Closed, ResolvedPublic
Actions

Assigned To
Ladsgroup
Authored By
Volker_E
Dec 3 2016, 1:25 AM
Tags
Referenced Files
F5421569: FR_new.png
Jan 30 2017, 7:50 PM
F5421570: FR_old.png
Jan 30 2017, 7:50 PM
F4983129: pasted_file
Dec 5 2016, 2:24 PM
F4983083: pasted_file
Dec 5 2016, 2:17 PM
F4983059: pasted_file
Dec 5 2016, 2:17 PM
F4956881: pasted_file
Dec 3 2016, 12:23 PM
F4956909: pasted_file
Dec 3 2016, 12:23 PM
Subscribers
aaron
Aklapper
gerritbot
Jackmcbarn
Jdforrester-WMF
Ladsgroup
Lothar
View All 11 Subscribers

Description

Aligning FlaggedRevision to WikimediaUI color palette received negative feedback by several users of Polish Wikipedia.
We need to look deeper into the before/after state and address the feedback about low legibility and problems on less distinction of the important parts: (Citing with help of Google Translate; Polish speakers might please correct this, if wrong):

Now pending edits are hardly highlighted and questionable - piercing bright. In my previous system it was better. The only thing that can change it, a better color distinction between doubtful editions and unlabeled or immediately passwords.

Details

SubjectRepoBranchLines +/-
Use darker yellow for .flaggedrevs-pendingmediawiki/extensions/FlaggedRevsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Dec 3 2016, 1:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2016, 1:25 AM
Volker_E mentioned this in M82: Color palette (Wikimedia Design Style Guide/WikimediaUI).Dec 3 2016, 1:27 AM
Volker_E added subscribers: aaron, Jackmcbarn.Dec 3 2016, 1:29 AM
Aklapper added a project: Design.Dec 3 2016, 12:01 PM
Ladsgroup added a comment.Dec 3 2016, 12:23 PM

Okay, I think I might know what's going on here.

pasted_file (238×1 px, 116 KB)

And
pasted_file (34×705 px, 10 KB)

These are RED90 and YELLOW90. IMO They should be 70 instead so they are bright enough and also not too dark (third use case for T151938: Add Yellow70 to the color palette)
But definitely @Volker_E knows better :)

PeterBowman subscribed.Dec 3 2016, 1:17 PM
Volker_E added a comment.Dec 3 2016, 7:07 PM

@Ladsgroup Are there any before (the patch) screenshots available to have a direct comparison of the change?

Stryn subscribed.Dec 3 2016, 7:10 PM
Ladsgroup added a comment.Dec 5 2016, 2:17 PM

I used Inspect Element and the patch values to show the difference:
Before the alignment:

pasted_file (131×1 px, 52 KB)

After:
pasted_file (132×1 px, 53 KB)

Ladsgroup added a comment.Dec 5 2016, 2:24 PM

Here's the old version of T152258#2843879:

pasted_file (29×768 px, 9 KB)

Ladsgroup added a comment.Dec 5 2016, 2:25 PM
This comment was removed by Ladsgroup.
Lothar subscribed.Dec 16 2016, 7:46 AM

Exactly. It was #FFEEAA color, which IMO was much more visible than present one.

Volker_E moved this task from Incoming to WMF Design Offsite 2017-01 on the Design board.Jan 5 2017, 5:06 PM
Volker_E added a project: Wikimedia-Design.Jan 5 2017, 10:24 PM
Volker_E moved this task from Backlog to WMF UI Std Offsite 2017-01 on the Wikimedia-Design board.Jan 5 2017, 10:27 PM
SamanthaNguyen subscribed.Jan 5 2017, 10:27 PM
Volker_E moved this task from WMF Design Offsite 2017-01 to Triaged on the Design board.Jan 5 2017, 10:36 PM
gerritbot subscribed.Jan 13 2017, 2:40 PM

Change 331983 had a related patch set uploaded (by Ladsgroup):
Use darker yellow for .flaggedrevs-pending

https://gerrit.wikimedia.org/r/331983

gerritbot added a project: Patch-For-Review.Jan 13 2017, 2:40 PM
matmarex unsubscribed.Jan 15 2017, 1:19 AM
gerritbot added a comment.Jan 22 2017, 1:28 AM

Change 331983 merged by jenkins-bot:
Use darker yellow for .flaggedrevs-pending

https://gerrit.wikimedia.org/r/331983

Volker_E reassigned this task from Volker_E to Ladsgroup.Jan 22 2017, 1:48 AM
Volker_E removed a project: Patch-For-Review.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2017, 1:48 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Jan 22 2017, 2:00 AM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.Jan 22 2017, 3:02 AM
Volker_E added a comment.Jan 30 2017, 7:11 PM

@PeterBowman @Stryn @Lothar It'd be great to get your feedback before closing this as resolved.

Stryn added a comment.Jan 30 2017, 7:44 PM

Looks better now, I've updated the colours on help page at fiwiki.

Volker_E added a comment.Jan 30 2017, 7:46 PM

@Stryn great, thanks!

PeterBowman added a comment.Jan 30 2017, 7:50 PM

Much better now, although I find it a bit too hard to tell the difference between unchecked pages and pending edits. Compare:

Old styles:

FR_old.png (248×1 px, 66 KB)

New styles:

FR_new.png (249×1 px, 66 KB)

On the other hand, I haven't observed any negative feedback on plwiki nor plwikt since the last changes.

Volker_E closed this task as Resolved.Jan 30 2017, 8:12 PM

@PeterBowman Thanks for the screenshots! I guess the silence derives from the fact, that the color is just another visual cue. It's already bolded and the background acts as additional amplifier. Will change this to resolved. If there are new comments, we can revisit.

Volker_E moved this task from WMF UI Std Offsite 2017-01 to Blocked/Waiting on the Wikimedia-Design board.Jan 30 2017, 8:12 PM
Lothar added a comment.Jan 31 2017, 2:16 PM

Like @PeterBowman wrote - much better than previous one

PeterBowman updated the task description. (Show Details)Jan 31 2017, 2:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits