Spotted in production with 1.29.0-wmf.5:
Fatal error: Call to undefined method ORES\Hooks::getDamagingThreshold() in /srv/mediawiki/php-1.29.0-wmf.4/extensions/ORES/includes/ApiHooks.php on line 117
Needs fixing before we roll out beyond group0.
Spotted in production with 1.29.0-wmf.5:
Fatal error: Call to undefined method ORES\Hooks::getDamagingThreshold() in /srv/mediawiki/php-1.29.0-wmf.4/extensions/ORES/includes/ApiHooks.php on line 117
Needs fixing before we roll out beyond group0.
Caused by rEORSc3ee00bc5c6f: Only pull in damaging scores when damaging model is enabled removing the function without noticing that it was now called by the newly-added API code.
I suppose so, I just noticed it after rolling out wmf.5 to group0. Time must've overlapped :)
Change 325624 had a related patch set uploaded (by Ladsgroup):
Use getThreshold instead of getDamagingThreshold
Change 325624 merged by jenkins-bot:
Use getThreshold instead of getDamagingThreshold
Mentioned in SAL (#wikimedia-operations) [2016-12-06T22:32:17Z] <Amir1> scap sync-dir php-1.29.0-wmf.4/extensions/ORES/includes/ 'Deploy gerrit:325624 (UBN! T152542)'
Mentioned in SAL (#wikimedia-operations) [2016-12-06T22:32:39Z] <ladsgroup@tin> Synchronized php-1.29.0-wmf.4/extensions/ORES/includes: Deploy gerrit:325624 (UBN! T152542) (duration: 00m 46s)
Change 325694 had a related patch set uploaded (by Ladsgroup):
Use getThreshold instead of getDamagingThreshold
Change 325694 merged by jenkins-bot:
Use getThreshold instead of getDamagingThreshold
Mentioned in SAL (#wikimedia-operations) [2016-12-06T22:43:29Z] <Amir1> scap sync-dir php-1.29.0-wmf.5/extensions/ORES/includes/ 'Deploy gerrit:325624 (UBN! T152542)'
Mentioned in SAL (#wikimedia-operations) [2016-12-06T22:43:58Z] <ladsgroup@tin> Synchronized php-1.29.0-wmf.5/extensions/ORES/includes: Deploy gerrit:325624 (UBN! T152542) (duration: 00m 45s)