Page MenuHomePhabricator
Create Task
Maniphest T153176

NWE: Can't edit transcluded sections
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to https://de.wikipedia.beta.wmflabs.org/wiki/Transkludierte_Testseite (or any other page that transcludes a template/page with sections).
  2. Edit a section in NWE.

Actual result:
You edit the whole source of Transkludierte_Testseite (which is just the transclusion).

Expected result:
Like in OWE, you should edit the respective section of "Testseite" instead, note that the edit URL has that page as title and a section starting with "T-".

Details

SubjectRepoBranchLines +/-
Allow 'T-' prefixed sections, and redirect if section link title isn't current pagemediawiki/extensions/VisualEditormaster+16 -6
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Dec 14 2016, 8:27 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 14 2016, 8:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Dec 14 2016, 11:41 PM

Looks like the API doesn't support section=T-1 :/

Esanders added a project: MediaWiki-Action-API.Dec 14 2016, 11:41 PM
Esanders added a subscriber: • Catrope.
Esanders added a comment.Dec 14 2016, 11:46 PM

Ignore that - I've misread the URL - we're going to have to do a redirect...

Esanders removed a project: MediaWiki-Action-API.Dec 14 2016, 11:47 PM
gerritbot subscribed.Dec 15 2016, 12:08 AM

Change 327398 had a related patch set uploaded (by Esanders):
Allow 'T-' prefixed sections, and redirect if section link title isn't current page

https://gerrit.wikimedia.org/r/327398

gerritbot added a project: Patch-For-Review.Dec 15 2016, 12:08 AM
Jdforrester-WMF assigned this task to Esanders.Dec 15 2016, 1:42 AM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Piramidion subscribed.Dec 18 2016, 9:20 PM
gerritbot added a comment.Jan 4 2017, 10:38 PM

Change 327398 merged by jenkins-bot:
Allow 'T-' prefixed sections, and redirect if section link title isn't current page

https://gerrit.wikimedia.org/r/327398

Jdforrester-WMF closed this task as Resolved.Jan 4 2017, 10:43 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 4 2017, 11:00 PM
Dvorapa subscribed.Jan 5 2017, 3:38 AM
matmarex mentioned this in T53675: VisualEditor: Section edit links don't work like wikitext where the section is transcluded from elsewhere.Sep 23 2022, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits