Page MenuHomePhabricator
Create Task
Maniphest T153567

Reverts with the API don't notify users anymore
Closed, ResolvedPublic
Actions

Description

Reverts with the API no longer notify users, see this report.

Details

SubjectRepoBranchLines +/-
Get undone revision id from hook param instead of requestmediawiki/extensions/Echomaster+22 -22
Customize query in gerrit

Related Objects

Event Timeline

Cenarium created this task.Dec 18 2016, 1:10 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 18 2016, 1:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cenarium added a comment.Dec 18 2016, 1:10 AM

I think this is due to the PageContentSaveComplete hook being inside a deferred update now. This causes the initial request to be $wgRequest instead of the derivative API request.

Cenarium added a comment.Dec 18 2016, 1:35 AM

Note: this is a distinct issue from T153570.

gerritbot subscribed.Dec 18 2016, 2:22 AM

Change 328028 had a related patch set uploaded (by Cenarium):
Get undone revision id from hook param instead of request

https://gerrit.wikimedia.org/r/328028

gerritbot added a project: Patch-For-Review.Dec 18 2016, 2:22 AM
Cenarium added a subscriber: • Catrope.Dec 18 2016, 3:13 AM
gerritbot added a comment.Dec 20 2016, 7:03 PM

Change 328028 merged by jenkins-bot:
Get undone revision id from hook param instead of request

https://gerrit.wikimedia.org/r/328028

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.Dec 20 2016, 7:05 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 20 2016, 8:00 PM
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Jan 3 2017, 1:35 PM
SBisson moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.
Etonkovidova subscribed.Jan 4 2017, 7:28 PM

QA recommendation: Resolve.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Jan 4 2017, 7:28 PM
• jmatazzoni closed this task as Resolved.Jan 5 2017, 6:23 PM
• jmatazzoni claimed this task.
matej_suchanek mentioned this in T154808: No longer getting Revert notifications.Jan 7 2017, 2:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits