Page MenuHomePhabricator

Notify users when undoing multiple revisions
Open, Needs TriagePublic

Description

It is possible to undo multiple users using the 'undoafter' param. This is used by tools like Twinkle to undo multiple revisions.
Currently, no user is notified when undoing multiple revisions since EditPage provides undidRev only when undoing a single edit.
EditPage would have to provide it along with a new undidAfterRev.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cenarium renamed this task from Notify all users when undoing multiple users to Notify users when undoing multiple revisions.Dec 23 2016, 1:54 AM
Cenarium updated the task description. (Show Details)

Change 329651 had a related patch set uploaded (by Cen.temp):
Add wpBaseRevision to edit request from 'undoafter' param

https://gerrit.wikimedia.org/r/329651

Change 330587 had a related patch set uploaded (by Cen.temp):
Notify users of multiple-revisions undos

https://gerrit.wikimedia.org/r/330587

Change 330587 had a related patch set uploaded (by Cen.temp):
Notify users of multiple-revisions undos

https://gerrit.wikimedia.org/r/330587

This change is probably going to break Echo in Wikibase again (T154808). So when this patch and the (not yet done) one in Wikibase are ready, could their deployment happen at the same time?

The patch for Wikibase consists in passing udoafter as base rev id, this can be merged before https://gerrit.wikimedia.org/r/330587.

Change 331990 had a related patch set uploaded (by Cenarium):
SubmitEntityAction: Pass 'undoafter' as base rev id

https://gerrit.wikimedia.org/r/331990

Change 608884 had a related patch set uploaded (by ProcrastinatingReader; owner: ProcrastinatingReader):
[mediawiki/extensions/Echo@master] Notify users of multi-revision undos and reverts

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/ /608884

Change 331990 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContent

https://gerrit.wikimedia.org/r/331990

Will include once T154637 has passed code review and we know which week it's going out.

(Unless that's already decided?)