Page MenuHomePhabricator
Create Task
Maniphest T153570

Notify users when undoing multiple revisions
Open, Needs TriagePublic
Actions

Description

It is possible to undo multiple users using the 'undoafter' param. This is used by tools like Twinkle to undo multiple revisions.
Currently, no user is notified when undoing multiple revisions since EditPage provides undidRev only when undoing a single edit.
EditPage would have to provide it along with a new undidAfterRev.

Details

SubjectRepoBranchLines +/-
Notify users of multi-revision reverts; EditResult-related cleanupmediawiki/extensions/Echomaster+952 -86
Notify users of multiple-revisions undos and assorted fixesmediawiki/extensions/Echomaster+48 -23
Create EditResult object, with info on a saved edit, pass it to hooksmediawiki/coremaster+260 -24
SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContentmediawiki/extensions/WikibaseREL1_35+15 -9
SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContentmediawiki/extensions/Wikibasemaster+15 -9
Customize query in gerrit

Related Objects

Event Timeline

Cenarium created this task.Dec 18 2016, 1:35 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 18 2016, 1:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Cenarium mentioned this in T153567: Reverts with the API don't notify users anymore.Dec 18 2016, 1:35 AM
Cenarium renamed this task from Notify all users when undoing multiple users to Notify users when undoing multiple revisions.Dec 23 2016, 1:54 AM
Cenarium updated the task description. (Show Details)
gerritbot subscribed.Dec 30 2016, 3:03 AM

Change 329651 had a related patch set uploaded (by Cen.temp):
Add wpBaseRevision to edit request from 'undoafter' param

https://gerrit.wikimedia.org/r/329651

gerritbot added a project: Patch-For-Review.Dec 30 2016, 3:03 AM
gerritbot added a comment.Jan 4 2017, 10:29 PM

Change 330587 had a related patch set uploaded (by Cen.temp):
Notify users of multiple-revisions undos

https://gerrit.wikimedia.org/r/330587

Cenarium mentioned this in T154637: Notify users when manually reverting to an older revision.Jan 5 2017, 12:43 AM
• jmatazzoni moved this task from Untriaged to Hot on the Collaboration-Team-Triage board.Jan 6 2017, 1:11 AM
Cenarium mentioned this in T146326: Determine if multi-reverted edits still send notifications to all non-IP users who were reverted.Jan 11 2017, 2:46 AM
matej_suchanek subscribed.EditedJan 11 2017, 6:49 PM
In T153570#2918055, @gerritbot wrote:

Change 330587 had a related patch set uploaded (by Cen.temp):
Notify users of multiple-revisions undos

https://gerrit.wikimedia.org/r/330587

This change is probably going to break Echo in Wikibase again (T154808). So when this patch and the (not yet done) one in Wikibase are ready, could their deployment happen at the same time?

Cenarium added a comment.Jan 13 2017, 4:38 PM

The patch for Wikibase consists in passing udoafter as base rev id, this can be merged before https://gerrit.wikimedia.org/r/330587.

gerritbot added a comment.Jan 13 2017, 4:51 PM

Change 331990 had a related patch set uploaded (by Cenarium):
SubmitEntityAction: Pass 'undoafter' as base rev id

https://gerrit.wikimedia.org/r/331990

Catrope mentioned this in T202951: Revert notification should not go to the sysop who protected the page in between edits.Aug 28 2018, 11:10 PM
Catrope merged a task: T202951: Revert notification should not go to the sysop who protected the page in between edits.
Catrope added subscribers: Huji, Catrope.
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 28 2018, 11:10 PM
Catrope moved this task from Inbox to Q2 2019-20 on the Growth-Team board.Jan 12 2019, 12:14 AM
JTannerWMF moved this task from Q2 2019-20 to Q1 2019-20 on the Growth-Team board.Jun 17 2019, 6:52 PM
Catrope mentioned this in T164307: Add Reverted filter to RecentChanges Filters.Feb 22 2020, 1:05 AM
Ostrzyciel mentioned this in T252366: Choose the definition of a "reverted" edit.May 11 2020, 7:18 AM
Ostrzyciel mentioned this in T254074: Implement the reverted edit tag.May 30 2020, 5:23 PM
Proc subscribed.Jun 20 2020, 5:08 PM
Proc claimed this task.Jun 30 2020, 3:42 PM
Proc moved this task from Backlog to In progress on the Notifications board.Jun 30 2020, 3:47 PM
Proc removed a project: Patch-For-Review.
gerritbot added a comment.Jul 1 2020, 2:10 PM

Change 608884 had a related patch set uploaded (by ProcrastinatingReader; owner: ProcrastinatingReader):
[mediawiki/extensions/Echo@master] Notify users of multi-revision undos and reverts

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/ /608884

gerritbot added a project: Patch-For-Review.Jul 1 2020, 2:10 PM
Proc added a subscriber: Ostrzyciel.Jul 1 2020, 2:58 PM
gerritbot added a comment.Jul 21 2020, 10:12 AM

Change 331990 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContent

https://gerrit.wikimedia.org/r/331990

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 21 2020, 6:01 PM
BEANS-X2 subscribed.Jul 23 2020, 1:39 PM
Ostrzyciel mentioned this in T248775: Proposal: Add Reverted filter to RecentChanges Filters.Aug 30 2020, 8:51 AM
matej_suchanek added a project: User-notice.Sep 16 2020, 8:09 AM

Together with T154637.

Johan subscribed.Sep 18 2020, 5:42 PM

Will include once T154637 has passed code review and we know which week it's going out.

(Unless that's already decided?)

Johan moved this task from To Triage to Not ready to announce on the User-notice board.Sep 18 2020, 5:43 PM
gerritbot added a comment.Mar 18 2021, 2:09 PM

Change 673277 had a related patch set uploaded (by Tobias Andersson; owner: Cenarium):
[mediawiki/extensions/Wikibase@REL1_35] SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContent

https://gerrit.wikimedia.org/r/673277

gerritbot added a comment.Mar 23 2021, 1:45 PM

Change 673277 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] SubmitEntityAction: Pass 'undoafter' and 'restore' to doEditContent

https://gerrit.wikimedia.org/r/673277

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:59 PM
Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 8:17 PM
Tacsipacsi mentioned this in T346507: Update FlaggedRevs to use the new HookContainer/HookRunner system.Nov 1 2023, 5:31 PM
Aklapper removed Proc as the assignee of this task.Nov 21 2023, 8:21 AM

@Proc: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits