Description

Currently the background of all framed images is grey (which is only visible for transparent images). On English Wikipedia this is overridden in MediaWiki:Common.css to make it white, but this isn't the case on other wikis.

English Wikipedia:

Screen Shot 2016-12-23 at 10.02.00 PM.png (230×281 px, 33 KB)

Spanish Wikipedia:

Screen Shot 2016-12-23 at 10.02.21 PM.png (234×288 px, 35 KB)

The CSS used on English Wikipedia is:

div.thumb .thumbimage {
    background-color: #fff;
}

Something similar to this should probably be added to the html .thumbimage rule in /resources/src/mediawiki.skinning/content.css.

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up I96d2225: Adding white background color to framed images in Parsoid	mediawiki/core	master	+1 -0
	Adding white background color to thumbimages (i.e. framed images)	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T329910: Set a minimum thumbnail width by default
T271114: Update site specific js/css for new media structure
T147768: Add a frame and caption text to <graph>

Event Timeline

kaldari created this task.Dec 24 2016, 6:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2016, 6:05 AM

Change 329029 had a related patch set uploaded (by Kaldari):
Adding white background color to thumbimages (i.e. framed images)

https://gerrit.wikimedia.org/r/329029

gerritbot added a project: Patch-For-Review.Dec 24 2016, 6:11 AM

matmarex closed this task as Resolved.Dec 27 2016, 11:52 AM

matmarex assigned this task to kaldari.

matmarex edited projects, added MediaWiki-User-Interface; removed Patch-For-Review, MediaWiki-General.

matmarex subscribed.

Change 329029 merged by jenkins-bot:
Adding white background color to thumbimages (i.e. framed images)

https://gerrit.wikimedia.org/r/329029

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 27 2016, 1:00 PM

Now that the patch is merged, the custom CSS on English Wikipedia should be removed on January 6 or later.

• JGirault mentioned this in T147768: Add a frame and caption text to <graph>.Jan 3 2017, 5:32 PM

Xaosflux subscribed.Feb 15 2017, 12:09 AM

This should be applied to Parsoid styles as well

Change 339402 had a related patch set uploaded (by Esanders):
Follow-up I96d2225: Adding white background color to framed images in Parsoid

https://gerrit.wikimedia.org/r/339402

gerritbot added a project: Patch-For-Review.Feb 23 2017, 1:09 PM

Change 339402 merged by jenkins-bot:
Follow-up I96d2225: Adding white background color to framed images in Parsoid

https://gerrit.wikimedia.org/r/339402

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)).Feb 23 2017, 3:00 PM

• MZMcBride subscribed.Mar 11 2017, 12:18 AM

Arlolra mentioned this in T271114: Update site specific js/css for new media structure.Jan 31 2023, 10:41 PM

Arlolra mentioned this in T329910: Set a minimum thumbnail width by default.Feb 17 2023, 12:34 AM

	F5147682: Screen Shot 2016-12-23 at 10.02.21 PM.png
	Dec 24 2016, 6:05 AM

	F5147680: Screen Shot 2016-12-23 at 10.02.00 PM.png
	Dec 24 2016, 6:05 AM

Backgrounds of framed images should be white, not greyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Backgrounds of framed images should be white, not grey
Closed, ResolvedPublic
Actions