Page MenuHomePhabricator

Backgrounds of framed images should be white, not grey
Closed, ResolvedPublic

Description

Currently the background of all framed images is grey (which is only visible for transparent images). On English Wikipedia this is overridden in MediaWiki:Common.css to make it white, but this isn't the case on other wikis.

English Wikipedia:

Spanish Wikipedia:

The CSS used on English Wikipedia is:

div.thumb .thumbimage {
    background-color: #fff;
}

Something similar to this should probably be added to the html .thumbimage rule in /resources/src/mediawiki.skinning/content.css.

Event Timeline

kaldari created this task.Dec 24 2016, 6:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2016, 6:05 AM

Change 329029 had a related patch set uploaded (by Kaldari):
Adding white background color to thumbimages (i.e. framed images)

https://gerrit.wikimedia.org/r/329029

matmarex closed this task as Resolved.Dec 27 2016, 11:52 AM
matmarex assigned this task to kaldari.
matmarex added a subscriber: matmarex.

Change 329029 merged by jenkins-bot:
Adding white background color to thumbimages (i.e. framed images)

https://gerrit.wikimedia.org/r/329029

Now that the patch is merged, the custom CSS on English Wikipedia should be removed on January 6 or later.

This should be applied to Parsoid styles as well

Change 339402 had a related patch set uploaded (by Esanders):
Follow-up I96d2225: Adding white background color to framed images in Parsoid

https://gerrit.wikimedia.org/r/339402

Change 339402 merged by jenkins-bot:
Follow-up I96d2225: Adding white background color to framed images in Parsoid

https://gerrit.wikimedia.org/r/339402