Page MenuHomePhabricator

Convert its-phabricator upstream repo which wmf maintains to bazel
Closed, ResolvedPublic

Description

Upstream have removed support for buck in gerrit here https://gerrit-review.googlesource.com/#/c/91587/ so we need bazel to be able to build its-phabricator now.

This will affect us upgrading to gerrit 2.14 as we will need bazel.

I have a patch that should do this here https://gerrit-review.googlesource.com/#/c/92911/

Event Timeline

Paladox triaged this task as High priority.Jan 23 2017, 4:55 PM
Paladox added a subscriber: demon.

Setting to high as this is a blocker for any future upgrades we do.

Setting to high as this is a blocker for any future upgrades we do.

So this task only ever needs to be handled if we ever upgrade to Gerrit 2.14? I don't see a task for that? Are you aware of near-by plans for such an upgrade, or why did you mark this task as urgent?

hashar lowered the priority of this task from High to Low.Jan 24 2017, 10:42 AM
hashar added a subscriber: hashar.

@Paladox mind filling a task to upgrade to Gerrit 2.14 and add this one as a sub task? Similar to T146350: Update gerrit to 2.13.3. Thank you!

Oh yep, though the 2.14 update haven't been released yet. But I can create the task in advanced.

I herd that upstream are planning an rc release in February / march.

Setting to high as this is a blocker for any future upgrades we do.

So this task only ever needs to be handled if we ever upgrade to Gerrit 2.14? I don't see a task for that? Are you aware of near-by plans for such an upgrade, or why did you mark this task as urgent?

As we build gerrit and the plugins, this could lead to it won't build.

I doint know if you can build gerrit with bazel but keep building plugins with buck.

That would also increase resources and memory as you will be using both.

though the 2.14 update haven't been released yet.

So this task wasn't urgent (= high priority). Please don't set the Priority field to "high" in such cases.

though the 2.14 update haven't been released yet.

So this task wasn't urgent (= high priority). Please don't set the Priority field to "high" in such cases.

Did you read my comment on why I set it as high pri?

It was also changed to low pri.

demon lowered the priority of this task from Low to Lowest.Jan 24 2017, 5:29 PM

Did you read my comment on why I set it as high pri?

@Paladox: Links are generally welcome to make sure people talk about the same things. If you refer to T156024#2961886 I'll say again there's no reason to set "high priority" if you do not know when "any future updates" will take place or if they actually will ever take place. Thanks.

Paladox claimed this task.

Patch was merged upstream. its-base and its-phabricator now support bazel.

All the plugins wikimedia uses have now been migrated to bazel, so no blockers on the plugin side of things, i've even converted half of there plugins too, so if we want to install new ones we can :)