Page MenuHomePhabricator

Issue of TwoColConflict with new Wikitext Editor
Closed, ResolvedPublic

Description

There is an issue when using TwoColConflict together with the new Wikitext editor. Both extensions are available as beat-features on beta, so the issue can be reproduced there by enabling both beta-features and going through a normal conflict resolution.

When a conflict occurs, a dialog is shown:

After clicking "resolve conflict" the TwoColConflict resolution-screen is shown including a new icon to switch back to visual editing:

After clicking the new icon, another dialog asks you again if you really want to switch back to visual editing (everything is fine until here):

Only after confirming the switch, the visual Wikitext editor loads again and the page is screwed up:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2017, 12:57 PM
WMDE-Fisch moved this task from Todo to Sprint ready on the WMDE-QWERTY-Team board.

We have a similar hack for the translation extension but really we should have an API for this. (ve.init.mw.DesktopArticleTarget.init.js, line 773)

@Esanders - so for now, we could also set some global JS variable and add a line for it there? :-)

Change 335017 had a related patch set uploaded (by WMDE-Fisch):
Disable VisualEditor in the TwoColConflict extension

https://gerrit.wikimedia.org/r/335017

Change 335018 had a related patch set uploaded (by WMDE-Fisch):
Set global JS variable to disable VE

https://gerrit.wikimedia.org/r/335018

Change 335017 merged by jenkins-bot:
Disable VisualEditor in the TwoColConflict extension

https://gerrit.wikimedia.org/r/335017

Change 335018 merged by jenkins-bot:
Set global JS variable to disable VE

https://gerrit.wikimedia.org/r/335018

Change 335025 had a related patch set uploaded (by WMDE-Fisch):
Only deactivte the switch button in the TwoColumnConflict extension

https://gerrit.wikimedia.org/r/335025

Tobi_WMDE_SW closed this task as Resolved.Jan 31 2017, 3:07 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.

Change 335025 abandoned by WMDE-Fisch:
Only deactivate the switch button in the TwoColumnConflict extension

Reason:
See comments.

https://gerrit.wikimedia.org/r/335025