Page MenuHomePhabricator

Explore feed - Lack of visibility of online status when connectivity is regained
Closed, ResolvedPublic2 Estimated Story Points

Description

Steps to reproduce

  1. Open Explore feed whilst offline
  2. Note that only some cards are shown on the Explore feed and a continuous circular loading indicator is shown
  3. Regain connectivity
  4. Tap on other sections in the app (e.g., reading lists, nearby)
  5. Return to the Explore feed

Actual

  • Screen continues to show circular loading gif as if items are load, with no explicit CTA to reload (user is meant to know to pull dow to refresh)
  • Explore continues to not be updated after connection is restored even after traversing to other sections of the app and returning
  • Some images half-loaded show as a pixelated checkered pattern

open to view animated gif

Offline - Explore - connection regained.gif (540×960 px, 2 MB)

Expected

  1. Feed provides explicit call to action to load more feed content
  2. When user navigates away from and then returns back to Explore via the bottom navigation, the Explore feed is updated to reflect regained online status

Mock for part 1 of expected
see Zeplin board https://zpl.io/Z1UvAFi mocks tagged "T157381 - Feed offline reload"
Note: the 'retry' message should replace the continuous circle loading animation as captured in T157341

Event Timeline

Change 350430 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia@master] Add OfflineCard/View to to the feed

https://gerrit.wikimedia.org/r/350430

Change 350465 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia@master] Hook up offline card Retry button

https://gerrit.wikimedia.org/r/350465

Change 350465 abandoned by Mholloway:
Hook up offline card Retry button

Reason:
Merged with the preceding patch

https://gerrit.wikimedia.org/r/350465

Change 350659 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Insert OfflineCard when offline

https://gerrit.wikimedia.org/r/350659

Change 350430 merged by jenkins-bot:
[apps/android/wikipedia@master] Add OfflineCard/View

https://gerrit.wikimedia.org/r/350430

Change 350659 merged by jenkins-bot:
[apps/android/wikipedia@master] Insert OfflineCard when offline

https://gerrit.wikimedia.org/r/350659

ABorbaWMF subscribed.

Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-26

Tried a few scenarios with losing and regaining connection. The explore feed is always refreshed after regaining connectivity.