Page MenuHomePhabricator

Make it impossible to set the same content in the same language for label and alias
Open, Stalled, LowestPublic

Description

BDD (similar to T212869):
GIVEN an Item or Property
WHEN adding a new label or alias in one language that leads to them being identical
OR changing an existing label or alias in one language that leads to them being identical
THEN an error is shown
AND the edit not saved

Acceptance criteria:

  • Given any Item or Property, it's not possible to save a pair label-alias with the same content in the same language via any interface.

Open questions:

  • Does it happen that, in order to convert an alias into a label, some software tries to add the label first (first edit) and then delete the alias (second edit)?

Event Timeline

Why shouldn't it be possible?

The label and the alias can't be the same (in that case, they're redundant). An alias (alternative name for an item) that is exactly the same as the label doesn't play any role, that alias isn't any alternative name for an item.

The label and the alias can't be the same (in that case, they're redundant). An alias (alternative name for an item) that is exactly the same as the label doesn't play any role, that alias isn't any alternative name for an item.

What if I need to make the alias the label? Or vice versa? Don't I need an intermediate step somewhere to duplicate one or the other?

No, you shouldn't need any intermediate step as you would continue being able to modify multiple labels and/or aliases in a single edit. In fact, if you need to make the alias the label, things would be easier because you would only have to add the label (the alias would be automatically removed on saving your changes).

Lydia_Pintscher changed the task status from Open to Stalled.Feb 27 2017, 9:46 AM
Lydia_Pintscher triaged this task as Lowest priority.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

It is currently not one edit. You click save once but that triggers multiple edits. They can result in issues as @Izno mentioned.

Thanks for noticing, @Lydia_Pintscher, and sorry for the mistake, @Izno.

Would this problem only arise in scenario 2? If so, perhaps 2 could behave like 1 while there's no better solution, that is to say...

  1. In a given item, if there's an alias "A"@lang and not a label "A"@lang, defining a label "A"@lang shouldn't be possible (until alias "A"@lang is manually removed).

Please note that you should take into account not only manual insertions (e.g. https://www.wikidata.org/w/index.php?title=Q957548&diff=1268719940&oldid=1268710970), but also insertions through QuickStatements (e.g. https://www.wikidata.org/w/index.php?title=Q957548&diff=1268710970&oldid=1259272612), OpenRefine and other tools for massive editing.

I think that "lowest" priority is maybe a bit too low. While a solution isn't found, maybe a bot can be programmed in order to remove duplicate aliases and (if possible) to send a standard warning message to the users who added them.

I think that "lowest" priority is maybe a bit too low. While a solution isn't found, maybe a bot can be programmed in order to remove duplicate aliases and (if possible) to send a standard warning message to the users who added them.

It might be time to revisit this task now that the very similar T212869 is resolved and the editing frequency is a problem at the technical level.

abian renamed this task from A label and an alias should never be the same in the same language and item in Wikidata to Make it impossible to set the same content in the same language for label and alias.Aug 31 2020, 3:10 PM
abian updated the task description. (Show Details)

I have simplified the description and removed from it the features that would never have been possible, leaving the description as in T212869.