| Volker_E | |
| Feb 10 2017, 8:15 PM |
| F5651120: Screen Shot 2017-02-16 at 10.40.28 AM.png | |
| Feb 16 2017, 5:19 AM |
| F5651124: Screen Shot 2017-02-16 at 10.40.52 AM.png | |
| Feb 16 2017, 5:19 AM |
| F5597360: T157834 Flagged ButtonWidget indicators – OOjs UI Demos 2017-02-10.png | |
| Feb 10 2017, 8:17 PM |
As of v0.19.1 OOjs UI demos feature ButtonWidgets with flagged (progressive) indicators.
This is a weak idea from an UI pattern perspective. It's also inconsistent between progressive and destructive widgets.
Originally, I intended to question using flags on indicators generally, but there might be use cases like colorizing the clear indicator of a CapsuleMultiselectWidget on :hover.
Expected outcome:
Limit indicators (on ButtonWidgets) to white/greyscale only.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki theme: Indicators shouldn't provide global 'progressive' flag | oojs/ui | master | +1 -2 |
As of v0.19.1 OOjs UI demos feature ButtonWidgets with flagged (progressive) indicators.
Are indicators the triangles that make these buttons act like drop-downs? Is it possible to have other kinds of indicators? Do we have examples of these in practice anywhere?
@Pginer-WMF I'd appreciate your inputs here.
The inconsistency does not make sense. I'm ok with triangles being greyscale only since the triangle can be seen as part of the control and not the label. As I mentioned before, I'm not sure how much this impacts our products in practice.
I couldn't find any examples in the wild for this, but the demo page has an alert indicator on a ButtonGroupWidget'. The capsules in a CapsuleMultiselectWidget` can sometimes be links, like in the case of CategorySelector, and have a close indicator. The CategorySelector shows a red link if the category is non-exsistent, but that is not the same as a destructive button, so not a 100% to the task.
| ButtonGroupWidget | CapsuleMultiselectWidget |
|---|---|
 |  |
All of the theoretically possible indicators are listed on https://doc.wikimedia.org/oojs-ui/master/demos/#icons-mediawiki-ltr-desktop. We definitely use 'clear', 'down' and 'required' in practice (although not usually on buttons). I'm not sure if we use any of the others anywhere.
Change 342551 had a related patch set uploaded (by VolkerE):
[oojs/ui] MediaWiki theme: Indicators shouldn't provide global 'progressive' flag
but there might be use cases like colorizing the clear indicator of a CapsuleMultiselectWidget on :hover
This should get converted to an icon soon.
Yes and I've also stated that the global flag is wrong. re-introducing flags on certain indicators (or even transforming them to iconElements) seems the more right way for me.
Change 342551 merged by jenkins-bot:
[oojs/ui] MediaWiki theme: Indicators shouldn't provide global 'progressive' flag