Page MenuHomePhabricator
Create Task
Maniphest T158869

Advanced search form contains <input type="hidden" name="profile" value="advanced"> twice
Closed, ResolvedPublic
Actions

Description

Advanced search form contains <input type="hidden" name="profile" value="advanced"> twice. This is harmless, but silly.

https://en.wikipedia.org/w/index.php?title=Special:Search&profile=advanced&fulltext=1&search=Wikipedia

pasted_file (525×901 px, 100 KB)

Details

SubjectRepoBranchLines +/-
Remove redundant input from search formmediawiki/coremaster+2 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 23 2017, 4:56 PM
Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptFeb 23 2017, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
debt triaged this task as Low priority.Mar 2 2017, 11:11 PM
debt added projects: good first task, patch-welcome.
debt moved this task from needs triage to This Quarter on the Discovery-Search board.
debt subscribed.

We think this is fairly easy to do. :)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 2 2017, 11:11 PM
EBernhardson subscribed.Mar 2 2017, 11:11 PM

This is probably somewhere in MediaWiki\Widget\Search\SearchFormWidget. This should be easier to figure out now since the refactor put this code into a more compact space.

EddieGP claimed this task.Mar 4 2017, 12:32 AM
gerritbot subscribed.Mar 4 2017, 12:41 AM

Change 341104 had a related patch set uploaded (by eddie):
[mediawiki/core] Remove redundant input from search form

https://gerrit.wikimedia.org/r/341104

gerritbot added a project: Patch-For-Review.Mar 4 2017, 12:41 AM
EddieGP moved this task from Backlog to Done on the good first task board.Mar 4 2017, 12:53 AM
gerritbot added a comment.Mar 5 2017, 4:28 PM

Change 341104 merged by jenkins-bot:
[mediawiki/core] Remove redundant input from search form

https://gerrit.wikimedia.org/r/341104

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 5 2017, 5:00 PM
Florian closed this task as Resolved.Mar 5 2017, 5:45 PM
EddieGP removed a project: Patch-For-Review.Mar 5 2017, 6:11 PM
matmarex merged a task: T85722: Duplicated url parameter profile=advanced in fulltext search.Jun 17 2017, 8:24 PM
matmarex added subscribers: Inkowik, • Deskana, StudiesWorld and 2 others.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits