Maniphest T159183

Consolidate image overflow logic in applib
Closed, InvalidPublic
Actions

Description

Consolidate the Android and iOS _JavaScript_ image overflow logic into one shared file within applib; most of this code appears to live in addImageOverflowContainers.js

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T163839 Phase one: consolidate the JavaScript transforms and associated CSS
		Resolved		• Fjalapeno	T152991 Audit iOS, Android and Mobile Web HTML, CSS, and JS
		Invalid		Mhurd	T159183 Consolidate image overflow logic in applib
		Resolved		Mhurd	T159193 Integrate consolidated image overflow logic into iOS app
		Resolved		• Niedzielski	T159194 Integrate consolidated image overflow logic into Android app

Event Timeline

• Niedzielski created this task.Feb 27 2017, 9:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2017, 9:53 PM

@Mhurd, @Fjalapeno there's a high similarity between these two implementations. This would be a good candidate second task to start after or in parallel the collapse element work.

• Niedzielski reassigned this task from • Niedzielski to Mhurd.Feb 27 2017, 10:21 PM

Mhurd created subtask T159193: Integrate consolidated image overflow logic into iOS app.Feb 27 2017, 11:23 PM

Mhurd created subtask T159194: Integrate consolidated image overflow logic into Android app.

Mhurd edited projects, added Wikipedia-iOS-App-Backlog (Administrative); removed Wikipedia-Android-App-Backlog.Feb 27 2017, 11:25 PM

Mhurd added a project: iOS-app-v5.4.0-Hiking-Boot.Feb 28 2017, 12:45 AM

Restricted Application edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (Administrative). · View Herald TranscriptFeb 28 2017, 12:45 AM

Mhurd added a project: Reading Epics (Platform JS CSS and HTML consolidation).Feb 28 2017, 12:47 AM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.4.0-Hiking-Boot board.Mar 2 2017, 5:42 PM

• NHarateh_WMF moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v5.4.0-Hiking-Boot board.Mar 2 2017, 8:16 PM

• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Mar 6 2017, 7:42 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.4.0-Hiking-Boot board.Mar 7 2017, 6:57 AM

Mhurd moved this task from Doing to Blocked or Waiting on the iOS-app-v5.4.0-Hiking-Boot board.Mar 7 2017, 7:42 PM

Mhurd moved this task from Blocked or Waiting to Doing on the iOS-app-v5.4.0-Hiking-Boot board.Mar 11 2017, 1:28 AM

• JMinor edited projects, added iOS-app-v5.4.1-Patchy-Boot; removed iOS-app-v5.4.0-Hiking-Boot.Mar 16 2017, 9:35 PM

Mhurd moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.4.1-Patchy-Boot board.Mar 17 2017, 1:16 AM

Mhurd mentioned this in T160970: Remove image overflow js transform (upstream provides this now).Mar 21 2017, 1:27 AM

Closing as invalid now that the image overflow transform has been deemed to be unnecessary and was remove by T160970.

• Niedzielski closed subtask T159193: Integrate consolidated image overflow logic into iOS app as Resolved.Apr 25 2017, 10:57 PM

Dbrant closed subtask T159194: Integrate consolidated image overflow logic into Android app as Resolved.May 15 2017, 3:12 PM