Page MenuHomePhabricator
Create Task
Maniphest T159428

RevisionSlider tooltip position broken on RTL languages
Closed, ResolvedPublic
Actions

Description

See screenshot. The issue was introduced with OOjs UI v0.19.2 but seems to be fixed in v0.19.4. The later is not deployed on production yet.

RevsiionSlider RTL Tooltips.png (900×1 px, 167 KB)

See as well: https://www.mediawiki.org/wiki/Topic:Tlyesrmx98oz50ce

Details

SubjectRepoBranchLines +/-
Refactor usage of OOjs UI tooltipsmediawiki/extensions/RevisionSlidermaster+74 -41
Quick fix for misplaced tooltips on RTL wikismediawiki/extensions/RevisionSliderwmf/1.29.0-wmf.14+5 -0
Quick fix for misplaced tooltips on RTL wikismediawiki/extensions/RevisionSlidermaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Mar 2 2017, 10:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2017, 10:26 AM
WMDE-Fisch added a comment.Mar 2 2017, 11:10 AM

When fixing this - e.g. by deploying v0.19.4 be aware, that this version will introduce a new issue: T159434

WMDE-Fisch added a comment.Mar 2 2017, 5:53 PM

More testing with v0.19.4 brought up another problem with RTL and popups:

The tooltips are not completly out of place but instead of shown centered under the revision hovered they show at the right end. See screenshot below, the mouse hovering over the red circled revision.

RevsiionSlider RTL Tooltips 0.19.14.png (921×1 px, 136 KB)

gerritbot subscribed.Mar 2 2017, 5:55 PM

Change 340779 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/RevisionSlider] Quick fix for misplaced tooltips on RTL wikis

https://gerrit.wikimedia.org/r/340779

gerritbot added a project: Patch-For-Review.Mar 2 2017, 5:55 PM
WMDE-Fisch mentioned this in rERSLce2c262b9c4c: Quick fix for misplaced tooltips on RTL wikis.Mar 2 2017, 5:55 PM
WMDE-Fisch claimed this task.Mar 2 2017, 5:55 PM
WMDE-Fisch moved this task from Proposed to Sprint ready on the WMDE-TechWish board.
gerritbot added a comment.Mar 2 2017, 6:47 PM

Change 340794 had a related patch set uploaded (by Addshore; owner: WMDE-Fisch):
[mediawiki/extensions/RevisionSlider] Quick fix for misplaced tooltips on RTL wikis

https://gerrit.wikimedia.org/r/340794

Addshore mentioned this in rERSL273b4e272b7c: Quick fix for misplaced tooltips on RTL wikis.Mar 2 2017, 6:48 PM
WMDE-Fisch mentioned this in rERSLc5b214fab9aa: Quick fix for misplaced tooltips on RTL wikis.Mar 3 2017, 9:02 AM
WMDE-Fisch moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Mar 3 2017, 12:00 PM
gerritbot added a comment.Mar 3 2017, 2:21 PM

Change 340981 had a related patch set uploaded (by wmde-fisch):
[mediawiki/extensions/RevisionSlider] Refactor usage of OOjs UI tooltips

https://gerrit.wikimedia.org/r/340981

WMDE-Fisch mentioned this in rERSLac93bbbaf5ee: Refactor usage of OOjs UI tooltips.Mar 3 2017, 2:21 PM
WMDE-Fisch added a comment.Mar 3 2017, 2:23 PM

https://gerrit.wikimedia.org/r/340981 fixes the tooltips for the current master and v0.19.4. Now they are used as intended and hopefully more stable when it comes to changes.

WMDE-Fisch mentioned this in rERSLfbac5c69a48b: Refactor usage of OOjs UI tooltips.Mar 3 2017, 2:31 PM
gerritbot added a comment.Mar 3 2017, 6:37 PM

Change 340794 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider] Quick fix for misplaced tooltips on RTL wikis

https://gerrit.wikimedia.org/r/340794

gerritbot added a comment.Mar 3 2017, 6:37 PM

Change 340779 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider] Quick fix for misplaced tooltips on RTL wikis

https://gerrit.wikimedia.org/r/340779

Stashbot subscribed.Mar 3 2017, 6:43 PM

Mentioned in SAL (#wikimedia-operations) [2017-03-03T18:43:06Z] <addshore@tin> Synchronized php-1.29.0-wmf.14/extensions/RevisionSlider/modules/ext.RevisionSlider.css: T159428 [[gerrit:340794|Quick fix for misplaced tooltips on RTL wikis]] (duration: 00m 42s)

Addshore subscribed.Mar 3 2017, 6:44 PM

Deployed.
It looks like this is only a partial fix, the tooltip is still miss-aligned, but at least it can now be seen on RTL wikis.

IKhitron added a comment.Mar 3 2017, 6:45 PM

Sorry, @Addshore, it can't.

Addshore added a comment.Mar 3 2017, 6:50 PM

@IKhitron it seems to be working for me!

pasted_file (645×1 px, 67 KB)

Could you attach a screenshot of how it appears for you?
Please make sure the CSS is not cached in your browser!

IKhitron added a comment.EditedMar 3 2017, 6:52 PM

It works now. Maybe it needed some time. I did then Ctrl-F5 and purge, didn't help, but now it's just fixed without changing something else. Thank you!

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 3 2017, 7:00 PM
Addshore triaged this task as High priority.Mar 4 2017, 5:20 PM
Addshore moved this task from Sprint ready to Done on the WMDE-TechWish board.
gerritbot added a comment.Mar 4 2017, 5:21 PM

Change 340981 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider] Refactor usage of OOjs UI tooltips

https://gerrit.wikimedia.org/r/340981

WMDE-Fisch added a comment.Mar 6 2017, 10:38 AM

It looks like this is only a partial fix, the tooltip is still miss-aligned, but at least it can now be seen on RTL wikis.

When https://gerrit.wikimedia.org/r/340981 is deployed this week the tooltip should be aligned completely fine again.

Tobi_WMDE_SW closed this task as Resolved.Mar 10 2017, 2:24 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Mar 14 2017, 4:04 PM
Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.Apr 15 2017, 7:18 AM
Volker_E removed projects: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:00 PM
Volker_E moved this task from Waiting for breaking release to Resolved outside releases on the OOUI board.Mar 22 2018, 5:42 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL