Author: stronk7

Description:
Hi,

we are using one AuthPlugin extension to provide unified accounts to our mediawiki site. The production server, using Mediawiki 1.5.8 works perfectly (http://docs.moodle.org), but we have found one problem when upgrading to Mediawiki 1.22.2 (http://docs.moodle.org/test):

First time users are properly validated and their information (username, email, real name) is copied perfectly to mediawiki tables.

But, non-first time users don't get this info updated (if they change it in the external DB).

I've been tracing a bit the problem and it seems that, in SpecialUserLogin.php, the processLogin() method only performs one $wgUser->saveSettings(); when there is one change in the "rememberpassword" option. And all the change performed by our AuthPlugin extension, and properly stored in $wgUser aren't saved at all.

Perhaps the $wgUser->saveSettings(); call should be out from the if? To be applied always the login is SUCCESS ?

I've assigned this to the "Special pages" component, because the bug is in one of them (SpecialUserLogin.php). Not sure if I should have used another component. Apologizes!

TIA and ciao, stronk7 :-)

Version: 1.11.x
Severity: normal
URL: http://docs.moodle.org/test