[Task] Provide RDF mapping for geoshape data type.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Mar 15 2017, 3:25 PM

Description

The RDF mapping of the geoshape datatype is not correct yet. Geoshapes are currently represented as strings in RDF, instead of the URLs of the actual shape.

In RdfBuilder::propertyIsLink(), there is a hard-coded list of data types that should be treated as URLs. geoshapes Need to be added to the list.

Conceptually, geoshapes should be handled similarly to the commonsMedia types in the RDF mapping. This means we need a GeoShapeRdfBuilder similar to CommonsMediaRdfBuilder, and RdfVocabulary::getGeoShapeURI similar to RdfVocabulary::getCommonsURI (which should probably be renamed to getMediaURI).

According to T161527: RFC: Canonical data URLs for machine readable page content, the canonical URL for pages in the Data namespace on commons should have the following form:

https://commons.wikimedia.org/data/main/Data:Xyz.map

Details

Subject	Repo	Branch	Lines +/-
Add RDF mapping for geo-shape data type [DNM]	mediawiki/extensions/Wikibase	master	+692 -443
Make GeoShapeRdfBuilder actually work	mediawiki/extensions/Wikibase	master	+98 -26
Add test for null implementation of GeoShape RDF mapping	mediawiki/extensions/Wikibase	master	+85 -3
Implement temporary null RDF mapping for GeoShapes	mediawiki/extensions/Wikibase	master	+43 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T91505 [Epic] Adding new datatypes to Wikidata (tracking)
Resolved	• Jonas	T57549 [Story] Add a new datatype for geoshapes
Resolved	Ladsgroup	T160535 [Task] Provide RDF mapping for geoshape data type.
Open	None	T163921 [Epic] Implement canonical data URLs for machine readable page content
Open	None	T163922 Create a URL rewrite to handle the /data/ path for canonical URLs for machine readable page content
Resolved	Ladsgroup	T163923 Create Special:PageData as a canonical entry point for machine readable page data.
Open	None	T177966 Add CORS-enabled, cacheable way to access contents of Data namespace
Open	None	T178184 Geoshapes and tabular data with spaces in title are exported to RDF with + instead of _

Event Timeline

Lydia_Pintscher created this task.Mar 15 2017, 3:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2017, 3:25 PM

@daniel can you clarify the problem with the current mapping and how it should be?

Hey I wanted to know more about the bug..

Bumping to high, since this blocks deployment IMHO. If we deploy without this mapping, we will end up with inconsistent data in the triple store once we fix this.

@Lydia_Pintscher i hope it's clear now.

daniel added a subtask: T159517: [RFC] RDF mapping for geo-shape / URIs for commons data pages.Mar 18 2017, 10:47 PM

Change 343361 had a related patch set uploaded (by Daniel Kinzler):
[mediawiki/extensions/Wikibase] Add RDF mapping for geo-shape data type [DNM]

https://gerrit.wikimedia.org/r/343361

gerritbot added a project: Patch-For-Review.Mar 18 2017, 10:51 PM

Change 343865 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase] Implement temporary null RDF mapping for GeoShapes

https://gerrit.wikimedia.org/r/343865

Change 343893 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase] Add test for null implementation of GeoShape RDF mapping

https://gerrit.wikimedia.org/r/343893

daniel updated the task description. (Show Details)Mar 21 2017, 7:21 PM

daniel updated the task description. (Show Details)

Change 343865 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Implement temporary null RDF mapping for GeoShapes

https://gerrit.wikimedia.org/r/343865

Change 343893 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Add test for null implementation of GeoShape RDF mapping

https://gerrit.wikimedia.org/r/343893

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 23 2017, 1:51 PM

Lydia_Pintscher merged a task: T163774: The query services seems to have a problem with the new geoshape datatype.Apr 25 2017, 8:45 PM

Lydia_Pintscher added a subscriber: ChristianKl.

Lucas_Werkmeister_WMDE mentioned this in T163910: Show geoshapes in Map view.Apr 26 2017, 2:46 PM

daniel edited subtasks, added: T163921: [Epic] Implement canonical data URLs for machine readable page content; removed: T159517: [RFC] RDF mapping for geo-shape / URIs for commons data pages.Apr 26 2017, 4:35 PM

daniel updated the task description. (Show Details)

Ladsgroup mentioned this in T166299: Figure out a process to keep the Wikibase ontology and documentation in sync.Jun 12 2017, 7:56 AM

Change 358911 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Make GeoShapeRdfBuilder actually work

https://gerrit.wikimedia.org/r/358911

Ladsgroup moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Jun 14 2017, 12:13 PM

@Smalyshev can we go ahead with this? shouldn't break anything, just add stuff for items that get edited. and we have a re-load coming up anyway, right?

In general, yes, but see my comments on the patch. PropertyRdfBuilder::propertyIsLink should be updated. If we don't have any GeoShape properties yet, it doesn't matter too much, and yes, we'll reload for T166244 as soon as we merge the patch.

We have two atm: https://www.wikidata.org/wiki/Special:ListProperties/geo-shape

Ladsgroup claimed this task.Jun 15 2017, 8:17 AM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 15 2017, 8:17 AM

Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Jun 15 2017, 8:55 AM

thiemowmde closed this task as Resolved.Jun 15 2017, 10:37 AM

thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

thiemowmde removed a project: Patch-For-Review.

Ladsgroup mentioned this in T167951: Provide RDF mapping for "tabular data" data type..Jun 15 2017, 10:44 AM

Change 358911 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make GeoShapeRdfBuilder actually work

https://gerrit.wikimedia.org/r/358911

Arsfiqball subscribed.Jun 28 2017, 3:26 AM

Lucas_Werkmeister_WMDE created subtask T178184: Geoshapes and tabular data with spaces in title are exported to RDF with + instead of _.Oct 13 2017, 5:10 PM

Change 343361 abandoned by Daniel Kinzler:
Add RDF mapping for geo-shape data type [DNM]