Page MenuHomePhabricator
Create Task
Maniphest T160539

Remove "editusercssjs" user rights from Translate, BlueSpiceFoundation, UserGroups extensions
Closed, ResolvedPublic
Actions

Description

Remove editusercssjs because it was depricated mediawiki 1.16

Targets

Occurrences of 'editusercssjs' in Directory *Courtesy blanked potential private info shown in DIR*

Found Occurrences (3 usages found)

Unclassified occurrence  (1 usage found)
    MediaWiki  (1 usage found)
        extensions/Translate/tests/phpunit  (1 usage found)
            messageindexdata.ser  (1 usage found)
                1editusercssjs
Usage in string constants  (2 usages found)
    MediaWiki  (2 usages found)
        extensions/BlueSpiceFoundation/includes  (1 usage found)
            DefaultSettings.php  (1 usage found)
                104"editusercssjs" => array(
        extensions/UserGroups  (1 usage found)
            UserRights.php  (1 usage found)
                81'editusercssjs', #deprecated

Details

SubjectRepoBranchLines +/-
Remove "editusercssjs" due to removal in MW-Coremediawiki/extensions/UserGroupsmaster+0 -1
Customize query in gerrit

Event Timeline

Zppix created this task.Mar 15 2017, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2017, 4:20 PM
Zppix moved this task from Unsorted to Needs removal on the Technical-Debt board.Mar 15 2017, 4:20 PM
Zppix added a subscriber: Reedy.
Aklapper added a comment.Mar 15 2017, 10:00 PM

"Remove" from what? Please see https://mediawiki.org/wiki/How_to_report_a_bug - thanks.

Zppix added a comment.EditedMar 16 2017, 12:40 PM

@Aklapper From any extensions I will be editing task description for a list of areas where it has been found by @Reedy

Zppix updated the task description. (Show Details)Mar 16 2017, 12:42 PM
Zppix updated the task description. (Show Details)
Aklapper renamed this task from [MediaWiki Extentsions] Remove editusercssjs user rights to Remove "editusercssjs" user rights from Translate, BlueSpiceFoundation, UserGroups extensions.Mar 16 2017, 3:08 PM
Amire80 added a subscriber: Nikerabbit.Mar 22 2017, 4:46 PM
TerraCodes subscribed.Mar 22 2017, 5:04 PM
Peachey88 added projects: MediaWiki-extensions-Translate, BlueSpice.Mar 22 2017, 7:47 PM
Nikerabbit added a comment.Mar 23 2017, 6:13 AM

messageindexdata.ser is just test data, ignore it.

Mglaser subscribed.Mar 23 2017, 8:55 AM

I'll have a look at this for BlueSpiceFoundation

Zppix added a comment.Mar 24 2017, 10:48 PM

Thanks @Nikerabbit and @Mglaser.

Nikerabbit removed a project: MediaWiki-extensions-Translate.Mar 29 2017, 1:00 PM
Mglaser added a comment.Mar 30 2017, 4:39 PM

Change is in code review: https://gerrit.wikimedia.org/r/345606

Aklapper added a comment.Mar 31 2017, 8:07 AM

(See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines to get automated notifications in corresponding Phabricator tasks)

Aklapper added a project: Patch-For-Review.Mar 31 2017, 8:08 AM
Zppix added a comment.Apr 2 2017, 1:42 AM

I'm still awaiting input from UserGroups

Mglaser added a comment.Apr 4 2017, 7:17 AM

Thanks @Aklapper for the pointer to commit messages. Will use this in the future. As of now: the BlueSpice commit was merged and we should no longer have any references to editusercssjs.

Zppix added a comment.Apr 7 2017, 8:39 PM

For some reason gerritbot didnt notice this change so heres the change for usergroups extension https://gerrit.wikimedia.org/r/346539

Umherirrender closed this task as Resolved.May 12 2017, 5:55 PM
gerritbot subscribed.May 12 2017, 6:00 PM

Change 346539 merged by jenkins-bot:
[mediawiki/extensions/UserGroups@master] Remove "editusercssjs" due to removal in MW-Core

https://gerrit.wikimedia.org/r/346539

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits