Page MenuHomePhabricator

Error in logs: Cannot read property '0' of undefined
Closed, ResolvedPublic

Description

Occasionally we can see these Parsoid errors in the RESTBase logs:

Cannot read property '0' of undefined
TypeError: Cannot read property '0' of undefined
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:251:33)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at Object.computeDSR [as proc] (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:670:2)
    at DOMPostProcessor.doPostProcess (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/DOMPostProcessor.js:428:7)
    at emitOne (events.js:96:13)
    at TreeBuilder.emit (events.js:188:7)
    at TreeBuilder.onEnd (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/HTML5TreeBuilder.js:134:7)
    at emitNone (events.js:86:13)
    at SyncTokenTransformManager.emit (events.js:185:7)
    at SyncTokenTransformManager.onEndEvent (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/TokenTransformManager.js:1002:8)
    at emitNone (events.js:86:13)
    at AsyncTokenTransformManager.emit (events.js:185:7)

A sample Wikipage for which it is happening is /en.wikipedia.org/v1/page/html/Neuromuscular_junction/776191415. The full logs can be seen in logstash.

Event Timeline

mobrovac created this task.Apr 19 2017, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2017, 2:49 PM
ssastry triaged this task as Medium priority.Apr 19 2017, 2:59 PM

Change 348988 had a related patch set uploaded (by Arlolra):
[mediawiki/services/parsoid@master] T163330: Fix regression from 906375ba

https://gerrit.wikimedia.org/r/348988

Change 348988 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T163330: Fix regression from 906375ba

https://gerrit.wikimedia.org/r/348988

Arlolra closed this task as Resolved.Apr 19 2017, 8:03 PM
Arlolra claimed this task.

Will be deployed Tue, Apr 25.