Page MenuHomePhabricator
Create Task
Maniphest T163330

Error in logs: Cannot read property '0' of undefined
Closed, ResolvedPublic
Actions

Description

Occasionally we can see these Parsoid errors in the RESTBase logs:

Cannot read property '0' of undefined
TypeError: Cannot read property '0' of undefined
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:251:33)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at computeNodeDSR (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:452:15)
    at Object.computeDSR [as proc] (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/pp/processors/computeDSR.js:670:2)
    at DOMPostProcessor.doPostProcess (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/DOMPostProcessor.js:428:7)
    at emitOne (events.js:96:13)
    at TreeBuilder.emit (events.js:188:7)
    at TreeBuilder.onEnd (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/HTML5TreeBuilder.js:134:7)
    at emitNone (events.js:86:13)
    at SyncTokenTransformManager.emit (events.js:185:7)
    at SyncTokenTransformManager.onEndEvent (/srv/deployment/parsoid/deploy-cache/revs/b067328ce462e239d65b3b69563064be437d6cea/src/lib/wt2html/TokenTransformManager.js:1002:8)
    at emitNone (events.js:86:13)
    at AsyncTokenTransformManager.emit (events.js:185:7)

A sample Wikipage for which it is happening is /en.wikipedia.org/v1/page/html/Neuromuscular_junction/776191415. The full logs can be seen in logstash.

Related Objects

Event Timeline

• mobrovac created this task.Apr 19 2017, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2017, 2:49 PM
ssastry triaged this task as Medium priority.Apr 19 2017, 2:59 PM
gerritbot subscribed.Apr 19 2017, 7:09 PM

Change 348988 had a related patch set uploaded (by Arlolra):
[mediawiki/services/parsoid@master] T163330: Fix regression from 906375ba

https://gerrit.wikimedia.org/r/348988

gerritbot added a project: Patch-For-Review.Apr 19 2017, 7:09 PM
gerritbot added a comment.Apr 19 2017, 7:49 PM

Change 348988 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T163330: Fix regression from 906375ba

https://gerrit.wikimedia.org/r/348988

Arlolra closed this task as Resolved.Apr 19 2017, 8:03 PM
Arlolra claimed this task.
• Pchelolo mentioned this in T163598: RESTbase 500s when asking for the latest revision of enwiki's [[Vomeronasal organ]].Apr 21 2017, 9:07 PM
ssastry subscribed.Apr 24 2017, 10:00 PM

Will be deployed Tue, Apr 25.

ssastry merged a task: T163598: RESTbase 500s when asking for the latest revision of enwiki's [[Vomeronasal organ]].Apr 24 2017, 10:01 PM
ssastry added subscribers: Jdforrester-WMF, • Pchelolo, Ragesoss.
Stashbot mentioned this in T153885: Parsoid doesn't handle templated template names yet.Apr 25 2017, 5:25 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-04-25T17:25:33Z] <arlolra> Updated Parsoid to rGPAR55b905111b3e (T153885, T163330, T89262, T154709, T162919, T161306)

Stashbot mentioned this in T89262: Read thumb sizes from siteinfo.Apr 25 2017, 5:25 PM
Stashbot mentioned this in T154709: Parsoid does not emit different HTML when the page=# property is set on paged media (PDFs/DjVus/TIFFs).
Stashbot mentioned this in T162919: Disable fostering lint error for category and other transparent tags.
Stashbot mentioned this in T161306: Investigate P-wrapping oddity that introduces long horizontal no-wrap lines on many navboxes on shwiki.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits