Bisect blames this on the upgrade to jQuery 3: https://gerrit.wikimedia.org/r/#/c/322812/
Pausing shows .wikiEditor-ui-top is empty
Esanders | |
Apr 25 2017, 3:34 PM |
F7755574: image.png | |
Apr 25 2017, 3:34 PM |
Bisect blames this on the upgrade to jQuery 3: https://gerrit.wikimedia.org/r/#/c/322812/
Pausing shows .wikiEditor-ui-top is empty
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Make toolbar and dialog part of the core module | mediawiki/extensions/WikiEditor | master | +42 -57 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Krinkle | T127328 Optimise critical rendering path | |||
Resolved | Krinkle | T124742 Upgrade to jQuery 3 | |||
Resolved | Esanders | T163793 Toolbar collapses while loading, causing page content to jump |
The problem is that wikiEditor is initialised twice, once in ext.wikiEditor.js without a toolbar, and once in ext.wikiEditor.toolbar.js with a toolbar. Previously these happened in one clock cycle despite both being wrapped document.ready calls ( $(fn) ), but I imagine this has changed with jQuery's changes to already resolved promises being async.
Having discussed with @Catrope and @TrevorParscal (the original authors) I think the best approach is to get rid of some of WikiEditor's modularity. The toolbar is essential to using the editor so should be merged into core. The dialog module is enabled by default, and making is disable-able servers no real purpose so enable that always too.
This will allow us to remove the empty initialisation and rely on the toolbar initialisation to load the editor.
Change 351681 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Make toolbar and dialog part of the core module
Change 351681 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Make toolbar and dialog part of the core module
It seems that this remove everything from the non-dialogs mode, but still actually 'goes' through the non-dialogs mode during setup, as described in T166857: The globe in WikiEditor disappears when loading is finished. I think that was an oversight...