Page MenuHomePhabricator
Create Task
Maniphest T163994

Argument 1 passed to FlaggedRevsUIHooks::addHideReviewedFilter() must be an instance of ChangesListSpecialPage
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

From fatalmonitor

Argument 1 passed to FlaggedRevsUIHooks::addHideReviewedFilter() must be an instance of ChangesListSpecialPage, SpecialNewpages given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php on line 318

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Apr 27 2017, 1:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2017, 1:50 PM
Aklapper added a project: MediaWiki-extensions-FlaggedRevs.Apr 27 2017, 2:44 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 27 2017, 2:44 PM
Reedy updated the task description. (Show Details)Apr 27 2017, 2:51 PM
SBisson added subscribers: • Mattflaschen-WMF, SBisson.Apr 27 2017, 3:11 PM

Caused by rEFLRc74c52046dd8: Update deprecated hooks regarding RecentChanges and Watchlist
ping @Mattflaschen-WMF

• mmodell triaged this task as High priority.Apr 27 2017, 7:43 PM
• mmodell added a parent task: T161733: MW-1.29.0-wmf.21 deployment blockers.
Reedy subscribed.Apr 27 2017, 7:44 PM

Just remove the type hint. I'll fix

• mmodell subscribed.Apr 27 2017, 7:44 PM

This is adding considerable logspam, not to mention that it's a fatal...

Reedy renamed this task from Argument 1 passed to FlaggedRevsUIHooks::addHideReviewedFilter() must be an instance of ChangesListSpecialPage, to Argument 1 passed to FlaggedRevsUIHooks::addHideReviewedFilter() must be an instance of ChangesListSpecialPage.Apr 27 2017, 7:45 PM
gerritbot subscribed.Apr 27 2017, 7:46 PM

Change 350651 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@master] Remove type hint on FlaggedRevsUIHooks::addHideReviewedFilter()

https://gerrit.wikimedia.org/r/350651

gerritbot added a project: Patch-For-Review.Apr 27 2017, 7:46 PM

Change 350652 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/FlaggedRevs@wmf/1.29.0-wmf.21] Remove type hint on FlaggedRevsUIHooks::addHideReviewedFilter()

https://gerrit.wikimedia.org/r/350652

gerritbot added a comment.Apr 27 2017, 7:54 PM

Change 350652 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.29.0-wmf.21] Remove type hint on FlaggedRevsUIHooks::addHideReviewedFilter()

https://gerrit.wikimedia.org/r/350652

Stashbot subscribed.Apr 27 2017, 7:59 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-27T19:59:46Z] <twentyafterfour@naos> Synchronized php-1.29.0-wmf.21/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php: deploy fix for T163994 (duration: 01m 04s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 27 2017, 8:00 PM
• mmodell added a comment.Apr 27 2017, 8:02 PM

Now it's:
Fatal error: Call to undefined method SpecialNewpages::registerFilterGroup() in /srv/mediawiki/php-1.29.0-wmf.21/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php on line 316

So @Reedy's fix wasn't really a fix :-/

Stashbot added a comment.Apr 27 2017, 8:03 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-27T20:03:03Z] <twentyafterfour> 1.29.0-wmf.21 is blocked by T163994

gerritbot added a comment.Apr 27 2017, 8:18 PM

Change 350662 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/FlaggedRevs@master] Fix filter on Special:NewPages

https://gerrit.wikimedia.org/r/350662

gerritbot added a comment.Apr 27 2017, 8:19 PM

Change 350651 abandoned by Reedy:
Remove type hint on FlaggedRevsUIHooks::addHideReviewedFilter()

https://gerrit.wikimedia.org/r/350651

gerritbot added a comment.Apr 27 2017, 8:22 PM

Change 350664 had a related patch set uploaded (by Reedy; owner: Mattflaschen):
[mediawiki/extensions/FlaggedRevs@wmf/1.29.0-wmf.21] Fix filter on Special:NewPages

https://gerrit.wikimedia.org/r/350664

gerritbot added a comment.Apr 27 2017, 8:40 PM

Change 350664 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.29.0-wmf.21] Fix filter on Special:NewPages

https://gerrit.wikimedia.org/r/350664

gerritbot added a comment.Apr 27 2017, 8:42 PM

Change 350662 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Fix filter on Special:NewPages

https://gerrit.wikimedia.org/r/350662

Stashbot added a comment.Apr 27 2017, 8:47 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-27T20:47:32Z] <twentyafterfour@naos> Synchronized php-1.29.0-wmf.21/extensions/FlaggedRevs: deploy fix for T163994 (duration: 01m 17s)

• mmodell closed this task as Resolved.Apr 27 2017, 8:57 PM
• mmodell claimed this task.
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 27 2017, 9:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL