Page MenuHomePhabricator
Create Task
Maniphest T164653

Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
Closed, ResolvedPublic
Actions

Description

https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml

Some of these rules seem fine to include in the default set by MediaWiki-Codesniffer too.

Details

SubjectRepoBranchLines +/-
Release v33.0.0mediawiki/tools/codesniffermaster+9 -2
Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer)mediawiki/tools/codesniffermaster+123 -0
Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffermediawiki/tools/codesniffermaster+125 -0
Add RedundantVarNameSniff from WikibaseCodeSniffermediawiki/tools/codesniffermaster+90 -7
Add InArrayUsageSniff from Wikibase CodeSniffermediawiki/tools/codesniffermaster+100 -0
Require that an explicit visiblity is set on methods and propertiesmediawiki/tools/codesniffermaster+10 -8
Check function definitions for the same variable namemediawiki/tools/codesniffermaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.May 6 2017, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2017, 7:37 PM
Reedy updated the task description. (Show Details)May 6 2017, 11:32 PM
Legoktm added a comment.May 12 2017, 9:07 PM

[14:00:46] <wikibugs> (PS1) Legoktm: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - https://gerrit.wikimedia.org/r/353653
[14:06:15] <wikibugs> (PS1) Legoktm: Make sure all files end with a newline [tools/codesniffer] - https://gerrit.wikimedia.org/r/353666

More to come

thiemowmde added a project: Wikidata.May 13 2017, 4:08 PM
thiemowmde added subscribers: • Aleksey_WMDE, Addshore.

It was mostly me pushing the additional rules in the Wikibase rule set. I would like to hear opinions from others and will not vote on these patches. ;-)

Ricordisamoa subscribed.Jun 23 2017, 4:15 PM
thiemowmde triaged this task as Medium priority.Oct 27 2017, 11:53 AM
gerritbot subscribed.Dec 17 2017, 7:22 AM

Change 398678 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Check function definitions for the same variable name

https://gerrit.wikimedia.org/r/398678

gerritbot added a project: Patch-For-Review.Dec 17 2017, 7:22 AM

Change 398679 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Require that an explicit visiblity is set on methods and properties

https://gerrit.wikimedia.org/r/398679

Legoktm added a comment.Dec 17 2017, 7:38 AM

I tried enabling Squiz.WhiteSpace.FunctionSpacing but it did not play well with global functions (probably needs an upstream bug report).

gerritbot added a comment.Dec 21 2017, 2:46 PM

Change 398678 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Check function definitions for the same variable name

https://gerrit.wikimedia.org/r/398678

gerritbot added a comment.Dec 21 2017, 2:48 PM

Change 398679 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Require that an explicit visiblity is set on methods and properties

https://gerrit.wikimedia.org/r/398679

Legoktm moved this task from Untriaged to In progress on the MediaWiki-Codesniffer board.Feb 14 2018, 7:19 PM
gerritbot added a comment.May 29 2018, 9:49 AM

Change 434646 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Legoktm):
[mediawiki/tools/codesniffer@master] Add InArrayUsageSniff from Wikibase CodeSniffer

https://gerrit.wikimedia.org/r/434646

gerritbot added a comment.May 29 2018, 12:31 PM

Change 434646 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add InArrayUsageSniff from Wikibase CodeSniffer

https://gerrit.wikimedia.org/r/434646

Addshore moved this task from incoming to monitoring on the Wikidata board.Aug 20 2018, 3:37 PM
Krinkle moved this task from In progress to Accepted rule changes on the MediaWiki-Codesniffer board.May 23 2020, 11:45 PM
gerritbot added a comment.Jun 10 2020, 2:53 PM

Change 603493 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/tools/codesniffer@master] Add RedundantVarNameSniff from WikibaseCodeSniffer

https://gerrit.wikimedia.org/r/603493

Legoktm mentioned this in T253624: Evaluate the future of wikibase-codesniffer.Jun 17 2020, 10:42 PM
gerritbot added a comment.Jun 21 2020, 6:51 PM

Change 603493 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add RedundantVarNameSniff from WikibaseCodeSniffer

https://gerrit.wikimedia.org/r/603493

gerritbot added a comment.Jun 30 2020, 3:09 PM

Change 603495 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/tools/codesniffer@master] Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer)

https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/ /603495

gerritbot added a comment.Jul 1 2020, 4:10 PM

Change 603496 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/tools/codesniffer@master] Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffer

https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/ /603496

gerritbot added a comment.Oct 26 2020, 3:33 PM

Change 603496 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add (optional) FullQualifiedClassNameSniff from WikibaseCodeSniffer

https://gerrit.wikimedia.org/r/603496

gerritbot added a comment.Oct 29 2020, 5:57 PM

Change 603495 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add optional ClassLevelLicense sniff (from WikibaseCodeSniffer)

https://gerrit.wikimedia.org/r/603495

Addshore added a comment.Oct 29 2020, 5:59 PM

@thiemowmde do you remember from your analysis if there were any others that it would make sense to move?
Per T253624#6373219 it looks like the requirements there are met and all the sniffs needed to retire wikibase-codesniffer are now in the mediawiki code sniffer (or will be in the next release)

Addshore added a project: User-Addshore.Oct 29 2020, 6:00 PM
Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.
Addshore closed this task as Resolved.Oct 29 2020, 6:07 PM
Addshore claimed this task.
Addshore reassigned this task from Addshore to thiemowmde.
Addshore mentioned this in T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer.
thiemowmde added a comment.EditedOct 29 2020, 6:49 PM

No, as far as I can see this was everything.

gerritbot added a comment.Oct 30 2020, 4:04 PM

Change 637591 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/codesniffer@master] Release v33.0.0

https://gerrit.wikimedia.org/r/637591

gerritbot added a comment.Oct 30 2020, 4:06 PM

Change 637591 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Release v33.0.0

https://gerrit.wikimedia.org/r/637591

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL