Page MenuHomePhabricator

Use the standalone Wikimedia UI library instead of RL
Open, LowestPublic

Description

Seems like something goes wrong during authentitication. Clicking on "Sett opp funksjonen" at no:Wikipedia:Etiketter, gets routed to m:Wiki labels#Installation, clicks https://labels.wmflabs.org/ui/ and "nowiki", routes to Mediawiki.org for log inn, routes back to http://labels.wmflabs.org/ui/nowiki/ and there something seems to go wrong.

Checking the console I find

"NetworkError: 404 NOT FOUND - http://labels.wmflabs.org/w/load.php?debug=false&lang=nb&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9"

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jeblad triaged this task as Unbreak Now! priority.May 28 2017, 4:45 PM
Paladox lowered the priority of this task from Unbreak Now! to Needs Triage.May 28 2017, 4:47 PM
Paladox subscribed.

Also this has nothing to do with phabricator. Could the title be changed please?

This seems like a critical error for this module to me, so I'm setting this to "Unbreak now", but note that this is not critical functionality on the nowiki, so in the bigger picture it is only "High".

jeblad renamed this task from Phabricator fails for nowiki to WikiLabels fails for nowiki.May 28 2017, 4:48 PM

This seems like a critical error for this module to me, so I'm setting this to "Unbreak now", but note that this is not critical functionality on the nowiki, so in the bigger picture it is only "High".

There is a high priority one. Unbreak Now means that everyone needs to stop what there doing and fix it.

Not sure why this ended up with Phabricator in the title, it is about WikiLabels in Ores.

Someone thinks this is not something that needs fixing, which don't make sense. I'll leave this bug and someone else must do the followup.

And no, it does not mean that everyone must stop working and fix it, it means someone working on ORES must check that WikiLabels in fact work, which it does not, and fix that part of the software, because it does not work anymore.

If my car stops working it is a critical bug for that car, not for the factory. It has to do with the scope of the broken iten and the context where it is used.

Anyhow, I have reported the bug, someone must fix it.

Not sure why this ended up with Phabricator in the title, it is about WikiLabels in Ores.

Someone thinks this is not something that needs fixing, which don't make sense. I'll leave this bug and someone else must do the followup.

Hi, i didn't say this did not need fixing just this is not an ubreak now task.

I didn't know about this bug otherwise I would've picked and fixed it way sooner. Please ping me if there is a bug related to wikilabels. It should be high but not UBN! As it only happens on nowiki and because of the differences between language code and wikipedia code (and stupid assumptions I've made when building this GUI). I fix it ASAP.

@jeblad Can you label edits? ignore the broken javascript (that I'm fixing), is there any problem on labeling edits?

There are several projects with the same situation, where prefix and language code does not match.

New error message:

error	
code	"forbidden"
message	"OAuth callback failed.  Are cookies disabled?"

Yes cookies are on, and yes Javascript is allowed. Actually the site is with exceptions.

At http://labels.wmflabs.org/ui/nowiki/ from both ordinary Firefox and private window.

GET http://labels.wmflabs.org/auth/whoami/

403 FORBIDDEN
		303ms

Request headers

Accept	
application/json, text/javascript, */*; q=0.01
Accept-Encoding	
gzip, deflate
Accept-Language	
en-US,en;q=0.5
Cookie	
beaker.session.id=_removed_
Host	
labels.wmflabs.org
Referer	
http://labels.wmflabs.org/ui/nowiki/
User-Agent	
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

Response headers

Content-Encoding	
gzip
Content-Type	
application/json
Date	
Tue, 30 May 2017 19:45:46 GMT
Server	
nginx/1.11.3

On Chromium in Incognito modus I'm routed back to http://labels.wmflabs.org/ui/ and nothing more happen. Reloding whit [shft] (hard reload) makes the page reload with "Campaigns" but no other chrome.

In Firefox running private browsing

http://labels.wmflabs.org/w/load.php?debug=false&lang=nb&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9

Response

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>404 Not Found</title>
<h1>Not Found</h1>
<p>The requested URL was not found on the server.  If you entered the URL manually please check your spelling and try again.</p>

Calls (but not, it was not in debug mode)

	<anonymous> https://no.wikipedia.org/w/load.php:74:993
	<anonymous> https://no.wikipedia.org/w/load.php:1:743
Ladsgroup removed a project: User-Ladsgroup.

Reload and the page opens with a set, and chose a specific training set and it too opens, but with no chrome or further explanation.

Wikilabels abuses ResourceLoader (to show buttons that resemble MediaWiki, I imagine) and RL uses domain-relative URLs for dynamically loading further styles. Should use the standalone Wikimedia UI library instead of RL. Probably priority:lowest though.

Halfak renamed this task from WikiLabels fails for nowiki to Use the standalone Wikimedia UI library instead of RL.Jun 15 2017, 2:41 PM
Halfak triaged this task as Lowest priority.
Halfak moved this task from Unsorted to Maintenance/cleanup on the Machine-Learning-Team board.

Could this please be removed to a clearer title? WikimediaUI is a Design specific term and doesn't fit any of the error descriptions in this task…