Page MenuHomePhabricator

Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS
Closed, ResolvedPublic

Description

Get the widget working correctly for both no-JS and JS.

Event Timeline

Change 354982 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@master] WIP: Update \n handling for HTMLUsersMultiselectField

https://gerrit.wikimedia.org/r/354982

Change 354982 merged by jenkins-bot:
[mediawiki/core@master] Fix \n handling for HTMLUsersMultiselectField

https://gerrit.wikimedia.org/r/354982

@TBolliger
Checked in betalabs - js Blacklist UsersMultiselectWidget works as expected.

For no-JS mode - all functionality works; there is no indication to a user what delimiters can be used for adding multiple usernames to the Block list:

Screen Shot 2017-07-03 at 11.46.10 AM.png (569×1 px, 45 KB)

@Etonkovidova — so can this ticket be closed as resolved?

We will fix the non-JS copy in T166626

@TBolliger - yes, the ticket can be marked as 'Resolved' .