Page MenuHomePhabricator
Create Task
Maniphest T192147

Regression: Changes to email blacklist or muted users do not activate Save button in Preferences
Closed, ResolvedPublic
Actions

Description

The Save button in Special:Preferences is supposed to only be greyed out until you change something. It remains greyed out if you only change the email blacklist at "Prohibit these users from emailing me" under "User profile", or the muted users at "Do not display notifications from these users" under "Notifications".

The Save button works if you also change another preference, but returns to greyed out if you change the other preference back before saving.
Tested in Firefox, Chrome and Edge at the English Wikipedia in Vector and MonoBook.
It was reported at https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=836235277#Unable_to_edit_Preferences

Details

SubjectRepoBranchLines +/-
Revert "Special:Preference: Check for changes before enabling Save button"mediawiki/coremaster+6 -4
mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClosemediawiki/coremaster+9 -7
mw.special.preferences.confirmClose: Handle textareasmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedmatmarexT192147 Regression: Changes to email blacklist or muted users do not activate Save button in Preferences
 ResolveddbarrattT173973 Preferences/Notification, Save button stays disable when editing Block list
Resolved• jmatazzoniT150419 Allow users to restrict who can send them notifications
 ResolveddbarrattT166626 Update message copy for Mute feature
 ResolvedCatropeT166836 Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS
 DuplicateNoneT175081 Update Mute message link to include Special:MyLanguage
 Resolved• Mattflaschen-WMFT166627 Internal error when you attempt to email a user you've blocked from Notifications
 Resolved• TBolligerT166835 Audit all notification types to see if any more should be exceptions
 Resolved• TBolligerT168489 Evaluate and decide if we need to capture any usage data for post-release analysis of Mute feature
 ResolvedNoneT169384 Blacklist UsersMultiselectWidget UI needs improvements
 Resolved• TBolligerT169606 Document how to restrict notifications received
 ResolveddbarrattT173475 Echo Notification Mute (Block List) can be bypassed by changing username
 ResolveddbarrattT177437 Update Echo and Run Maintenance Script
 ResolveddbarrattT173838 Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled
 ResolvedJohanT168902 Ping Johan and Translators mailing list about Echo Notifications blacklist strings
 OpenNoneT174485 UsersMultiselectWidget should throw error if unselected text is present onSubmit
 ResolvedMooeypooT188886 TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused

Event Timeline

PrimeHunter created this task.Apr 13 2018, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2018, 12:30 PM
Xaosflux triaged this task as Medium priority.Apr 13 2018, 12:53 PM
Xaosflux added a project: Notifications.
Xaosflux subscribed.

Some keywords for searches:
echo-pref-notifications-blacklist does not activate saveprefs

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 13 2018, 12:53 PM
Xaosflux updated the task description. (Show Details)Apr 13 2018, 2:22 PM
Xaosflux added a parent task: T173973: Preferences/Notification, Save button stays disable when editing Block list .
Xaosflux added projects: Anti-Harassment, Regression.Apr 13 2018, 2:24 PM
Restricted Application added a subscriber: MGChecker. · View Herald TranscriptApr 13 2018, 2:24 PM
Xaosflux renamed this task from Changes to email blacklist or muted users do not activate Save button in Preferences to Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.Apr 13 2018, 2:25 PM
Xaosflux moved this task from Untriaged to Snackbox on the Anti-Harassment board.Apr 13 2018, 2:39 PM
dbarratt removed a parent task: T173973: Preferences/Notification, Save button stays disable when editing Block list .Apr 13 2018, 4:50 PM
dbarratt added a subtask: T173973: Preferences/Notification, Save button stays disable when editing Block list .
• TBolliger moved this task from Snackbox to Product/Tech backlog on the Anti-Harassment board.Apr 13 2018, 6:09 PM
• TBolliger moved this task from Product/Tech backlog to Triage/To be Estimated on the Anti-Harassment board.Apr 13 2018, 6:18 PM
• TBolliger added subscribers: Samwilson, • TBolliger.Apr 13 2018, 6:24 PM

Hmm, weird. We haven't touched this in a while. I wonder if it's related to Global Preferences and T190353? We should check with @Samwilson to make sure we don't make his project any more difficult.

Previous ticket: T173973

TheDJ subscribed.Apr 13 2018, 7:23 PM

@TBolliger maybe due to https://gerrit.wikimedia.org/r/#/c/423364/ ?

Samwilson added a comment.Apr 14 2018, 12:37 AM

I don't think this is related to GlobalPreferences. The closest current issue is T190902: Usernames remain disabled when enabling local exception for email-blacklist, so I wonder if there are just some peculiarities about that widget.

gerritbot subscribed.Apr 16 2018, 1:27 AM

Change 426835 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Revert "Special:Preference: Check for changes before enabling Save button"

https://gerrit.wikimedia.org/r/426835

gerritbot added a project: Patch-For-Review.Apr 16 2018, 1:27 AM
GTrang subscribed.Apr 16 2018, 1:31 AM
In T192147#4130609, @TheDJ wrote:

@TBolliger maybe due to https://gerrit.wikimedia.org/r/#/c/423364/ ?

I have uploaded a patch that reverts https://gerrit.wikimedia.org/r/#/c/423364/.

gerritbot added a comment.Apr 17 2018, 1:13 PM

Change 427105 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.special.preferences.confirmClose: Handle textareas

https://gerrit.wikimedia.org/r/427105

gerritbot added a comment.Apr 17 2018, 1:13 PM

Change 427106 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose

https://gerrit.wikimedia.org/r/427106

matmarex subscribed.Apr 17 2018, 1:16 PM

These patches should also resolve the issue, but if no one is able to review them soon, you should merge and backport the revert instead.

gerritbot added a comment.Apr 17 2018, 3:50 PM

Change 427105 merged by jenkins-bot:
[mediawiki/core@master] mw.special.preferences.confirmClose: Handle textareas

https://gerrit.wikimedia.org/r/427105

gerritbot added a comment.Apr 17 2018, 3:55 PM

Change 427106 merged by jenkins-bot:
[mediawiki/core@master] mw.widgets.UsersMultiselectWidget: Compat with mw.special.preferences.confirmClose

https://gerrit.wikimedia.org/r/427106

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 17 2018, 4:01 PM
gerritbot added a comment.Apr 17 2018, 4:32 PM

Change 426835 abandoned by Bartosz Dziewoński:
Revert "Special:Preference: Check for changes before enabling Save button"

Reason:
No longer needed.

https://gerrit.wikimedia.org/r/426835

Jdforrester-WMF edited projects, added Verified; removed Patch-For-Review.Apr 17 2018, 4:35 PM
Jdforrester-WMF subscribed.

Confirmed fixed in Beta Cluster.

matmarex closed this task as Resolved.Apr 17 2018, 4:35 PM
matmarex claimed this task.

This change should be deployed to Wikimedia wikis this week, reaching English Wikipedia on Thursday, per the usual release schedule.

• TBolliger moved this task from Triage/To be Estimated to AHT Sprint 33 on the Anti-Harassment board.Nov 19 2018, 9:47 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment.
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 19 2018, 9:47 PM
• TBolliger moved this task from Ready to Archive of tickets closed outside this sprint, but need someplace to go on the Anti-Harassment (AHT Sprint 33) board.Nov 19 2018, 9:48 PM
Schnark mentioned this in T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.Oct 25 2019, 7:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits