The language associated with a Lexeme should be editable via the UI. It should be done with a regular item selector.
Editing should be persistent.
Estimation: M
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata | |||
| Resolved | Addshore | T168260 Deploy WikibaseLexeme extension on Wikimedia cluster | |||
| Resolved | Addshore | T191457 Deploy WikibaseLexeme on www.wikidata.org | |||
| Resolved | Addshore | T191458 Deploy WikibaseLexeme on test.wikidata.org | |||
| Resolved | Lydia_Pintscher | T168263 WikibaseLexeme functional baseline | |||
| Resolved | WMDE-leszek | T168298 UI for editing a Lexeme's language (M) | |||
| Resolved | WMDE-leszek | T168300 UI for editing a Lexeme's lexical category (S) |
Event Timeline
Comment Actions
This involves a change to how the language and lexical category are present in the "view mode" too:
Edit mode would look like:
Note, the above have been originally created by @Jan_Dittrich and later lamely edited by me, so don't mind the ugly details I've introduced. Above mocks are to give the overview how it should look like.
Comment Actions
Note, the above have been originally created by @Jan_Dittrich and later lamely edited by me, so don't mind the ugly details I've introduced.
Get's across what is important, I think. If people have open questions UI wise, tell me.
Comment Actions
Notes from story time:
- We have two times a language label. The bottom one is the general language, the top one (of which you can add several versions) is for the spelling variant, or regional variant etc.
- In the top language fields, the current implementation has language codes. @Jan_Dittrich finds language codes, particular ones for unusual language variants problematic (because to many users they will be gibberish). Thus, Jan prefers natural language labels like "Old nothern english" (which still could have code-aliases)
- There are some visual changes like position of labels, adding padding around the blue box and adjusting some sizes.
Comment Actions
Change 381000 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Make lexeme language and lexical category editable.
Comment Actions
Change 381000 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make lexeme language and lexical category editable.
Comment Actions
The patch only allows to change this field at all. It still does not match the desired UI. It is just a text field where you could put Q-ID (as a text). It is intended to be an "item selector" (you can find the language item by its "label" not by knowing Q-ID by heart), and also show the "label" of the language item, not (just) its ID. So the remaining part still needs to be done. As no one is currently working on it, it was moved back to Backlog.
Comment Actions
Notes from estimation discussion today:
- API for this already exists
- item selector already exists
- edit button already exists
Not necessary:
- No specific selector to only select a subset of items
Acceptance criteria:
- selector behaves and look like the existing item selector
- edits are persistent
Comment Actions
Change 386390 had a related patch set uploaded (by WMDE-leszek; owner: Jonas Kress (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LemmaHeader language and lexical category formatting
Comment Actions
Change 386390 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LemmaHeader language and lexical category formatting