| Etonkovidova | |
| Jun 19 2017, 5:44 PM |
| F8574591: Screen Shot 2017-06-28 at 4.57.03 PM.png | |
| Jun 29 2017, 9:21 PM |
| F8574585: Screen Shot 2017-06-29 at 1.03.19 PM.png | |
| Jun 29 2017, 9:21 PM |
| F8479650: Screen Shot 2017-06-19 at 9.33.48 PM.png | |
| Jun 19 2017, 5:44 PM |
| F8479648: Screen Shot 2017-06-19 at 9.33.35 PM.png | |
| Jun 19 2017, 5:44 PM |
| F8479644: Screen Shot 2017-06-19 at 9.34.17 PM.png | |
| Jun 19 2017, 5:44 PM |
| F8479641: Screen Shot 2017-06-19 at 9.34.08 PM.png | |
| Jun 19 2017, 5:44 PM |
Previously, the 'Namespace' and 'Tag filter' options occupied a place between two horizontal lines:
Now, in betalabs, when 'Namespace' and 'Tag filter' options became filters, the space between two horizontal lines is empty:
Also, the following mockup does not have any extra empty space preserved:
http://pauginer.github.io/prototypes/edit-review/extended-filters/index.html
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RCFilters: Remove <hr> if extension table is empty | mediawiki/core | master | +4 -0 |
Both the access to the advanced filters (T167384) and the position of the legend (T168043) are expected to change. Once the mentioned tickets are completed, we'll be making a better use of space.
I see the current situation to be an intermediate state, and efforts are probably better spent in completing the above tickets towards the final solution rather than adjusting the spacing of such intermediate state.
Thx, @Pginer-WMF. I thought that we would deploy Namespace and Tag filters before finishing the entire work, i.e. T167384 and T168043. I'll keep the ticket in Collaboration-Team -Triage, just in case.
Just to verify something -- those two lines may actually have something left in there from external extensions. For example, I'm a bit confused about where "Translations" went in your second set of screenshots... it should still remain, since we did not yet implement it in RCFilters.
I can try and check whether there's anything visible between those lines, and if not, I can hide them, but it is a bit of a hack.
Change 361609 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Remove <hr> if extension table is empty
Change 361609 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Remove <hr> if extension table is empty
Checked in betalabs - the screenshots below are from betalabs cawiki
With the legend collapsed
With the un-collapsed legend
QA Recommendation: Resolve