Set up debug parameter for QA of page previews eventlogging
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Background

In order to debug the EventLogging instrumentation in production environments, we want to be able to bucket ourselves at will.

AC

When ?debug=true, the EventLogging instrumentation is enabled.
When ?debug=false or not specified, the user is bucketed as usual.
This happens regardless of whether the user is logged in/out.

Notes

Developers: Use mw.config.get( 'debug' ).

Details

	Subject	Repo	Branch	Lines +/-
	Hygiene: i13n: Return false over not sampling	mediawiki/extensions/Popups	master	+8 -18
	Override eventLogging to enabled when debug flag is on	mediawiki/extensions/Popups	master	+16 -2

Customize query in gerrit

Related Objects

Mentioned In: T167365: Check whether a 'disabled' event is sent when the user disables the feature and fix if the event is not sent
Mentioned Here: rEPOP9303d03ee305: Hygiene: i13n: Return false over not sampling

Event Timeline

ovasileva created this task.Jun 26 2017, 11:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2017, 11:06 AM

phuedx updated the task description. (Show Details)Jun 26 2017, 11:10 AM

ovasileva triaged this task as High priority.Jun 26 2017, 12:01 PM

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Jun 27 2017, 12:32 PM

Jdlrobson updated the task description. (Show Details)Jun 27 2017, 4:23 PM

Jdlrobson set the point value for this task to 1.

^ Ugh.

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jun 27 2017, 4:50 PM

Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.Jun 27 2017, 5:24 PM

• Tbayer subscribed.Jun 28 2017, 5:08 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 28 2017, 5:15 PM

pmiazga claimed this task.Jun 30 2017, 4:04 PM

pmiazga moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Change 362434 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/Popups@master] Override eventLogging to enabled when debug flag is on

https://gerrit.wikimedia.org/r/362434

gerritbot added a project: Patch-For-Review.Jun 30 2017, 4:22 PM

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 30 2017, 4:33 PM

Change 362434 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Override eventLogging to enabled when debug flag is on

https://gerrit.wikimedia.org/r/362434

pmiazga removed pmiazga as the assignee of this task.Jul 3 2017, 12:06 PM

pmiazga removed a project: Patch-For-Review.

pmiazga moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

pmiazga subscribed.

Change 362977 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] Hygiene: i13n: Return false over not sampling

https://gerrit.wikimedia.org/r/362977

gerritbot added a project: Patch-For-Review.Jul 3 2017, 12:27 PM

rEPOP9303d03ee305: Hygiene: i13n: Return false over not sampling doesn't block signoff. It's just something I noticed during code review that's somewhat related to this task.

phuedx updated the task description. (Show Details)Jul 3 2017, 12:32 PM

phuedx updated the task description. (Show Details)

Signing off.
When visiting https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?debug=true I can see events for page previews. great!

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 2:01 AM

pmiazga mentioned this in T167365: Check whether a 'disabled' event is sent when the user disables the feature and fix if the event is not sent.Jul 14 2017, 1:24 PM

Change 362977 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Hygiene: i13n: Return false over not sampling