background
Schema:Popups specifies that a 'disabled' event is to be sent when "the feature was explicitly disabled by the user (i.e., went from on to off)", but so far zero such events have been logged in the new instrumentation:
SELECT event_action, COUNT(*) FROM log.Popups_16364296 GROUP BY event_action; +---------------------+----------+ | event_action | COUNT(*) | +---------------------+----------+ | dismissed | 565552 | | dwelledButAbandoned | 3331201 | | opened | 137255 | | pageLoaded | 54803 | | tapped settings cog | 254 | +---------------------+----------+ 5 rows in set (13.35 sec)
acceptance criteria
- Check whether a 'disabled' event is sent when the user disables the feature
- fix if no event is sent - event is not sent
- ensure it works for anymous users (via settings cog)
- ensure it works for logged-in users (via preferences page)