This field appears to have gotten lost at some point:
SELECT DISTINCT event_pageTitleHover, COUNT(*) FROM log.Popups_16364296 WHERE DATE(timestamp) = '2017-05-01'; +----------------------+----------+ | event_pageTitleHover | COUNT(*) | +----------------------+----------+ | NULL | 60407 | +----------------------+----------+ 1 row in set (1.20 sec)
Probably also applies to namespaceIdHover.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dereckson | T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki) | |||
| Resolved | Jdlrobson | T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature | |||
| Resolved | ovasileva | T154635 [EPIC] Deploy page previews to English and German Wikipedia | |||
| Resolved | ovasileva | T162672 Deploy page previews to 90% of users on all wikis but English and German | |||
| Resolved | • Tbayer | T158172 Analyze results of stage 0 page previews test | |||
| Resolved | • Tbayer | T164256 pageTitleHover not set correctly in Popups schema | |||
| Resolved | phuedx | T173422 Investigate the increase in the number of requests to Swift after the Page Previews deploy |
Change 351605 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] eventLogging: Add missing perceivedWait property
This is a little more complicated than I originally thought as there's a little debt around the selection of which links that PP should act on (see src/processLinks.js). I think it's worthwhile taking the time to move from:
to:
Change 351605 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] eventLogging: Add missing perceivedWait property
Change 352868 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] eventLogging: Round perceivedWait property
Change 352868 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] eventLogging: Round perceivedWait property
Change 352870 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] WIP eventLogging: Add missing *Hover properties
@Tbayer: rEPOP35cfc38b0b85: eventLogging: Add missing perceivedWait property and rEPOP2d3f5333b54b: eventLogging: Round perceivedWait property will be deployed to the group1 and group2 Wikipedias today and tomorrow during the 8 PM UTC MediaWiki train deployment.
Change 352870 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] eventLogging: Add missing *Hover properties
@Tbayer: rEPOP35bf61396451: eventLogging: Add missing *Hover properties will've been deployed to all of the Wikipedias by EOD Thursday, 18th.
You mean sanity-check the incoming data after it is deployed on Thursday, and then record the assessment here? Will do that.
Change 353903 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] actions: Mix title and namespaceID into LINK_DWELL
Change 353903 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] actions: Mix title and namespaceID into LINK_DWELL
Per T164256#3264140, this can't be verified in production until EOD Thursday, 18th, though we should start to see the properties being populated by EOD today (since the changes will've been deployed to the group1 Wikipedias).
T164256#3270064 would've been true if the train deployments had been running this week. Unfortunately, they aren't. I'll deploy rEPOP35bf61396451: eventLogging: Add missing *Hover properties and rEPOPcf0ea9db7bde: actions: Mix title and namespaceID into LINK_DWELL on Monday, 22nd.
I didn't get around to deploying those changes. I'll deploy them during tomorrow's European Mid-day SWAT.
@phuedx - just to confirm, we're swat-ing one part of this tomorrow, and the remainder will be on the train for Thursday.
Despite the fact that the changes should be live on ca- and hewiki, there've been no events with the pageTitleHover or namespaceIdHover properties set logged in the last couple of days [0][1].
SELECT DISTINCT event_pageTitleHover, COUNT(*) FROM log.Popups_16364296 WHERE DATE(timestamp) = '2017-05-24'; +----------------------+----------+ | event_pageTitleHover | COUNT(*) | +----------------------+----------+ | NULL | 57726 | +----------------------+----------+
SELECT DISTINCT event_pageTitleHover, COUNT(*) FROM log.Popups_16364296 WHERE DATE(timestamp) = '2017-05-25'; +----------------------+----------+ | event_pageTitleHover | COUNT(*) | +----------------------+----------+ | NULL | 24057 | +----------------------+----------+
Ignore the above (T164256#3291677) per [0][1].
SELECT wiki, COUNT(*) AS n FROM log.Popups_16364296 WHERE event_pageTitleHover IS NOT NULL AND timestamp LIKE '20170524%' GROUP BY wiki; +--------+----------+ | wiki | n | +--------+----------+ | cawiki | 31 | | hewiki | 493 | +--------+----------+
SELECT wiki, COUNT(*) AS n FROM log.Popups_16364296 WHERE event_pageTitleHover IS NOT NULL AND timestamp LIKE '20170525%' GROUP BY wiki; +--------+----------+ | wiki | n | +--------+----------+ | cawiki | 393 | | hewiki | 1613 | +--------+----------+
Signing this off is blocked by T166345: wmf/1.30.0-wmf.2 performance issue for Wikipedias as the -wmf.2 branch hasn't been deployed to the group2 wikis.
21 of the 52649 events logged on Sunday, 4th June didn't have their pageTitleHover property set [0][1] so 👍
However, there appear to be 2 remaining bugs:
select event_action, count(*) as n from log.Popups_16364296 where event_pageTitleHover is null and timestamp like '20170604%' group by event_action; +---------------------+----+ | event_action | n | +---------------------+----+ | dwelledButAbandoned | 14 | | pageLoaded | 5 | | tapped settings cog | 2 | +---------------------+----+
select count(*) as n from log.Popups_16364296 where timestamp like '20170604%'; +-------+ | n | +-------+ | 52649 | +-------+
select event_action, count(*) as n from log.Popups_16364296 where event_pageTitleHover is not null and timestamp like '20170604%' group by event_action; +---------------------+-------+ | event_action | n | +---------------------+-------+ | dismissed | 6652 | | dwelledButAbandoned | 44077 | | opened | 1899 | +---------------------+-------+
Change 357570 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[mediawiki/extensions/Popups@master] eventLogging: Add missing properties to "tapped settings cog" event
Change 357570 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] eventLogging: Add missing properties to "tapped settings cog" event
The above patch has been +2'ed. I noticed a couple of things while reviewing though.
Good catch! I checked and at least some of these events are logged, albeit lacking the link interaction token (filed as T167364).
Regarding 1., did you also try to click further, disable the feature and check whether the 'disabled' event is sent? (Probably not, as the new schema has logged zero such events so far - filed as T167365.)
Regarding 2., what's the expected behavior again after the rewrite?
#1. No, I didn't go further.
#2. From the tests I gathered a new 'tapped settings cog' should be logged as the settings dialog is displayed. @phuedx maybe able to correct me.
That's my understanding but the description of the action is ambiguous here. @Tbayer: At the moment, PP will not log a tapped settings cog event when the footer link is clicked, which I think is a bug. Should it?
Discussed this with @ovasileva and while we agree that this is the desired behavior, it's also low priority compared to fixing the other current instrumentation issues. I have filed a new task for whenever we get around to it: T167835
Checked that (almost) all relevant events have a non-null value for pageTitleHover now:
SELECT DATE(timestamp) AS date, SUM(IF(event_pageTitleHover IS NOT NULL, 1, 0))/SUM(1) FROM log.Popups_16364296 WHERE MONTH(timestamp) >= 5 AND event_linkInteractionToken IS NOT NULL GROUP BY date ORDER BY date; +------------+--------------------------------------------------------+ | date | SUM(IF(event_pageTitleHover IS NOT NULL, 1, 0))/SUM(1) | +------------+--------------------------------------------------------+ | 2017-05-01 | 0.0000 | | 2017-05-02 | 0.0000 | | 2017-05-03 | 0.0000 | | 2017-05-04 | 0.0000 | | 2017-05-05 | 0.0000 | | 2017-05-06 | 0.0000 | | 2017-05-07 | 0.0000 | | 2017-05-08 | 0.0000 | | 2017-05-09 | 0.0000 | | 2017-05-10 | 0.0000 | | 2017-05-11 | 0.0000 | | 2017-05-12 | 0.0000 | | 2017-05-13 | 0.0000 | | 2017-05-14 | 0.0000 | | 2017-05-15 | 0.0000 | | 2017-05-16 | 0.0000 | | 2017-05-17 | 0.0000 | | 2017-05-18 | 0.0000 | | 2017-05-19 | 0.0000 | | 2017-05-20 | 0.0000 | | 2017-05-21 | 0.0000 | | 2017-05-22 | 0.0000 | | 2017-05-23 | 0.0000 | | 2017-05-24 | 0.0091 | | 2017-05-25 | 0.1081 | | 2017-05-26 | 0.0380 | | 2017-05-27 | 0.0430 | | 2017-05-28 | 0.0644 | | 2017-05-29 | 0.0491 | | 2017-05-30 | 0.0338 | | 2017-05-31 | 0.0482 | | 2017-06-01 | 0.1758 | | 2017-06-02 | 0.9932 | | 2017-06-03 | 0.9967 | | 2017-06-04 | 0.9997 | | 2017-06-05 | 0.9996 | | 2017-06-06 | 0.9999 | | 2017-06-07 | 0.9995 | | 2017-06-08 | 0.9999 | | 2017-06-09 | 0.9999 | | 2017-06-10 | 1.0000 | | 2017-06-11 | 0.9998 | | 2017-06-12 | 1.0000 | | 2017-06-13 | 1.0000 | +------------+--------------------------------------------------------+ 44 rows in set (7.26 sec)