There is no possibility to check changes on user options save.
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When user hits Save on Special:Preferences page MediaWiki core triggers 3 events

PreferencesFormPreSave
UserSaveOptions
UserSaveSettings

But all three events are triggered after setting new options in user object: https://github.com/wikimedia/mediawiki/blob/master/includes/Preferences.php#L1505
There is no possibility to compare new options with the one stored previously.

Context: we would like to track users who changed one option from enabled to disabled and trigger a bespoke action.

Pre-signoff Actions

~~Update~~ Actually write [the PreferencesFormPreSave documentation](https://www.mediawiki.org/wiki/Manual:Hooks/PreferencesFormPreSave).

Details

	Subject	Repo	Branch	Lines +/-
	Pass old user options in PreferencesFormPreSave hook	mediawiki/core	master	+79 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Resolved	ovasileva	T162672 Deploy page previews to 90% of users on all wikis but English and German
Resolved	• Tbayer	T158172 Analyze results of stage 0 page previews test
Resolved	phuedx	T167365 Check whether a 'disabled' event is sent when the user disables the feature and fix if the event is not sent
Resolved	Jdlrobson	T169365 There is no possibility to check changes on user options save.
Resolved	phuedx	T173422 Investigate the increase in the number of requests to Swift after the Page Previews deploy

Event Timeline

pmiazga created this task.Jun 30 2017, 8:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2017, 8:22 PM

pmiazga mentioned this in T167365: Check whether a 'disabled' event is sent when the user disables the feature and fix if the event is not sent.Jun 30 2017, 8:26 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Jul 3 2017, 4:07 PM

pmiazga claimed this task.Jul 4 2017, 5:33 PM

pmiazga added projects: Readers-Web-Kanbanana-Board-Old, Unplanned-Sprint-Work.

pmiazga moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

I'll reuse the existing PreferencesFormPreSave event, and add one parameter array $oldOptions which would be a set of user options before change

Change 363224 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/core@master] Pass old user options in PreferencesFormPreSave hook

https://gerrit.wikimedia.org/r/363224

gerritbot added a project: Patch-For-Review.Jul 4 2017, 6:32 PM

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 4 2017, 6:34 PM

pmiazga moved this task from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Jul 4 2017, 10:11 PM

phuedx triaged this task as High priority.Jul 5 2017, 10:01 AM

phuedx updated the task description. (Show Details)Jul 5 2017, 10:12 AM

ovasileva moved this task from Needs Prioritization to 2016-17 Q4 on the Web-Team-Backlog board.Jul 5 2017, 11:46 AM

pmiazga moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jul 5 2017, 1:40 PM

Jdlrobson added a parent task: T167365: Check whether a 'disabled' event is sent when the user disables the feature and fix if the event is not sent.Jul 5 2017, 5:10 PM

We determined this is a subtask and does not need estimation.

Change 363224 merged by jenkins-bot:
[mediawiki/core@master] Pass old user options in PreferencesFormPreSave hook

https://gerrit.wikimedia.org/r/363224

phuedx moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jul 5 2017, 6:12 PM

All that's left to be done is

Actually write the PreferencesFormPreSave documentation.

… Done.

Reading Web didn't get around to estimating this yesterday. I'm being bold and estimating this as a 2. Any arguments for lower or higher? /cc @Jdlrobson

phuedx reassigned this task from pmiazga to Jdlrobson.Jul 6 2017, 10:12 AM