Page MenuHomePhabricator

File purging should also purge the thumbnails of old versions
Closed, ResolvedPublic

Description

It seems like currently only the purgeChangedFiles.php maintenance script purges thumbnails of old versions of the file. action=purge, as well as the API, only seem to purge thumbnails of the current version.

Relevant snippet from WikiFilePage.php:

$this->mFile->purgeCache( [ 'forThumbRefresh' => true ] );

And from purgeChangedFiles.php:

// Purge current version and its thumbnails
$file->purgeCache();
// Purge the old versions and their thumbnails
foreach ( $file->getHistory() as $oldFile ) {
    $oldFile->purgeCache();
}

Event Timeline

Gilles created this task.Jun 29 2017, 10:35 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 29 2017, 10:35 AM

Change 362199 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/core@master] Make file purging also purge old versions

https://gerrit.wikimedia.org/r/362199

Change 362199 merged by jenkins-bot:
[mediawiki/core@master] Make file purging also purge old versions

https://gerrit.wikimedia.org/r/362199

Gilles closed this task as Resolved.Aug 7 2017, 4:54 PM