Service-based thumbnailing re-architecture in production with Thumbor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Dec 14 2015, 12:33 PM

Description

The goal of this task is to remove our dependency on MediaWiki for generating thumbnails in Wikimedia production.

This task does not include moving MediaWiki to a full sha1-based URL scheme for thumbnails and originals. That can be achieved separately (T66214, T19577).

It does not include getting rid of Swift for thumbnail storage, which will be tackled in a follow-up project.

It does not include getting rid of Mediawiki parsing originals metadata, as this is not a task Thumbor was designed to do. Another service would be needed to remove that functionality from Mediawiki.

Strategy for deployment in Wikimedia production:

Thumbor is stateless and acts as drop-in for current MediaWiki PHP image scalers
Thumbor will remain behind Varnish
Thumbor will be integrated at the Swift level (rewrite.py)

Details

Subject	Repo	Branch	Lines +/-
thumbor: use memorysize_mb fact for unit MemoryLimit	operations/puppet	production	+1 -1
thumbor: bump MemoryLimit to 15%	operations/puppet	production	+1 -1
thumbor: use jessie-backports as target release for python-thumbor-wikimedia	operations/puppet	production	+7 -1
Increase Swift timeout for Thumbor	operations/puppet	production	+1 -1
hieradata: have thumbor.svc alert critical	operations/puppet	production	+0 -1
hieradata: use thumbor.svc for codfw too	operations/puppet	production	+2 -0
swift: disable thumbor shadow traffic	operations/puppet	production	+0 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	• Gilles	T121388 Service-based thumbnailing re-architecture in production with Thumbor
Resolved	• Gilles	T111718 Service-based thumbnailing re-architecture on Vagrant
Resolved	• dpatrick	T114414 Thumbor Security Review
Invalid	• Gilles	T121392 Thumbor production puppet
Resolved	• Gilles	T134488 Package Thumbor Community Core for Debian
Duplicate	• Gilles	T134486 (Re-)package Thumbor for Debian
Duplicate	• Gilles	T134487 Package libthumbor for Debian
Duplicate	• Gilles	T123281 Swift on beta
Resolved	• Gilles	T123412 Address small security issues found in Thumbor during security review
Resolved	fgiunchedi	T134485 Package Thumbor for Debian
Resolved	• Gilles	T139606 add thumbor to production infrastructure
Resolved	• Gilles	T140275 Review production MediaWiki configuration for wiki-specific thumbnailing settings
Resolved	• Gilles	T141260 Integration tests for thumbor wikimedia extensions
Resolved	• Gilles	T141337 Upgrade to python-thumbor-wikimedia >= 1.0.5
Invalid	• Gilles	T144413 thumbor content-disposition should be set to the thumbnail file name
Resolved	• Gilles	T144414 thumbor more aggressive timeouts when talking to swift
Resolved	• Gilles	T144415 do not require thumbor allow_unsafe_urls for swift integration to work
Resolved	• Gilles	T144478 thumbor statsd metrics not pushed to STATSD_HOST
Resolved	• Gilles	T144481 thumbor sharded swift container should happen before projlang rewrite
Resolved	• Gilles	T144479 Ensure thumbor container access is preserved by mw filebackend setzoneaccess
Resolved	• Gilles	T150746 Nginx timeouts on Thumbor
Resolved	• Gilles	T151441 Thumbor should handle "temp" thumbnail requests
Resolved	• Gilles	T151067 Implement rate limiter in Thumbor
Resolved	• Gilles	T151066 Implement PoolCounter support in Thumbor
Resolved	• Gilles	T151065 Implement DC-local cache failure limiter in Thumbor
Resolved	• Gilles	T150754 Thumbor can't render a few SVGs that Mediawiki can
Declined	• Gilles	T150741 Thumbor should reject thumbnail requests that are the same size as the original or bigger
Resolved	• Gilles	T151553 Add request URL to thumbor errors
Resolved	• Gilles	T167462 Support PNG thumbnails of WebP originals in Thumbor
Resolved	• Gilles	T167490 Disable Thumbor dual-serving
Resolved	• Gilles	T167782 Deploy Thumbor to group0 wikis
Resolved	• Gilles	T167783 Re-enable saving Thumbor thumbnails to Swift
Resolved	• Gilles	T167793 Deploy Thumbor to group1 wikis
Resolved	• Gilles	T167794 Deploy Thumbor to all wikipedias
Resolved	• Gilles	T167795 Deploy Thumbor to Commons
Resolved	• Gilles	T167796 Deploy Thumbor to all remaining wikis
Resolved	fgiunchedi	T167801 Deploy thumbor in codfw
Resolved	• Cmjohnson	T168297 Rename mw1236 / mw1237 to thumbor1003 / thumbor1004
Declined	• Gilles	T168929 Identify source of gadget/extension pointing to thumb.php on imagescalers
Resolved	• Gilles	T168949 Proper thumbnails of portrait photos not being generated; serious display issues
Open	None	T169316 Thumbor should alert/page when thumbs aren't rendered
Resolved	fgiunchedi	T171468 thumbor.svc intermittent timeout on pybal and icinga
		· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

fgiunchedi created subtask T144481: thumbor sharded swift container should happen before projlang rewrite.Sep 1 2016, 10:20 AM

• Gilles closed subtask T144413: thumbor content-disposition should be set to the thumbnail file name as Invalid.Sep 1 2016, 10:42 AM

• Gilles closed subtask T141260: Integration tests for thumbor wikimedia extensions as Resolved.Sep 1 2016, 11:41 AM

• Gilles closed subtask T144478: thumbor statsd metrics not pushed to STATSD_HOST as Resolved.Sep 5 2016, 9:00 AM

fgiunchedi closed subtask T144481: thumbor sharded swift container should happen before projlang rewrite as Resolved.Sep 6 2016, 9:51 AM

fgiunchedi closed subtask T144415: do not require thumbor allow_unsafe_urls for swift integration to work as Resolved.Sep 6 2016, 10:00 AM

Change 309029 had a related patch set uploaded (by Filippo Giunchedi):
swift: disable thumbor shadow traffic

https://gerrit.wikimedia.org/r/309029

gerritbot added a project: Patch-For-Review.Sep 7 2016, 4:20 PM

Change 309029 merged by Filippo Giunchedi:
swift: disable thumbor shadow traffic

https://gerrit.wikimedia.org/r/309029

• Gilles closed subtask T144414: thumbor more aggressive timeouts when talking to swift as Resolved.Sep 13 2016, 8:08 AM

fgiunchedi created subtask T145497: thumbor/derpconf should default to loading *.conf from config directory.Sep 13 2016, 9:34 AM

• Gilles removed a subtask: T145497: thumbor/derpconf should default to loading *.conf from config directory.Oct 13 2016, 5:47 AM

• Gilles moved this task from Backlog to Doing on the Thumbor board.Oct 13 2016, 5:54 AM

Jdforrester-WMF subscribed.Nov 18 2016, 5:48 PM

• Gilles removed a parent task: T141317: Provide a beta feature of ImageTweaks.Nov 22 2016, 4:45 PM

• Gilles moved this task from Doing to Backlog on the Thumbor board.Nov 24 2016, 4:00 PM

• Gilles moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.Dec 6 2016, 12:29 AM

• Gilles moved this task from Backlog to Doing on the Thumbor board.Dec 6 2016, 2:25 PM

• Gilles closed subtask T139606: add thumbor to production infrastructure as Resolved.Dec 6 2016, 2:30 PM

• Gilles added a subtask: T144479: Ensure thumbor container access is preserved by mw filebackend setzoneaccess.

• Gilles added a subtask: T150746: Nginx timeouts on Thumbor.

• Gilles added a subtask: T151441: Thumbor should handle "temp" thumbnail requests.

• Gilles added a subtask: T151067: Implement rate limiter in Thumbor.

• Gilles added a subtask: T151066: Implement PoolCounter support in Thumbor.Dec 6 2016, 2:32 PM

• Gilles added a subtask: T151065: Implement DC-local cache failure limiter in Thumbor.

• Gilles added a subtask: T150754: Thumbor can't render a few SVGs that Mediawiki can.

• Gilles added a subtask: T150741: Thumbor should reject thumbnail requests that are the same size as the original or bigger.

• Gilles added a subtask: T151553: Add request URL to thumbor errors.

• Gilles moved this task from Doing (old) to To-do: Goals prioritized current Quarter on the Performance-Team board.Dec 22 2016, 10:42 AM

• Mholloway subscribed.Jan 16 2017, 9:39 PM

• Gilles closed subtask T150754: Thumbor can't render a few SVGs that Mediawiki can as Resolved.Jan 20 2017, 8:54 AM

• Gilles closed subtask T151441: Thumbor should handle "temp" thumbnail requests as Resolved.Jan 24 2017, 9:13 AM

fgiunchedi reopened subtask T151441: Thumbor should handle "temp" thumbnail requests as Open.Feb 1 2017, 8:48 AM

• Gilles closed subtask T151441: Thumbor should handle "temp" thumbnail requests as Resolved.Feb 1 2017, 12:45 PM

• Gilles closed subtask T151066: Implement PoolCounter support in Thumbor as Resolved.Feb 1 2017, 7:47 PM

• Gilles closed subtask T151067: Implement rate limiter in Thumbor as Resolved.

• Gilles removed a project: Patch-For-Review.Mar 21 2017, 10:23 AM

• Gilles closed subtask T150746: Nginx timeouts on Thumbor as Resolved.Mar 28 2017, 3:11 PM

• Gilles closed subtask T151553: Add request URL to thumbor errors as Resolved.Mar 30 2017, 4:20 PM

• Gilles closed subtask T151065: Implement DC-local cache failure limiter in Thumbor as Resolved.May 29 2017, 12:47 PM

• Gilles created subtask T167462: Support PNG thumbnails of WebP originals in Thumbor.Jun 8 2017, 7:46 PM

• Gilles created subtask T167490: Disable Thumbor dual-serving.Jun 9 2017, 5:25 AM

• Gilles closed subtask T167462: Support PNG thumbnails of WebP originals in Thumbor as Resolved.Jun 9 2017, 3:09 PM

• Gilles closed subtask T150741: Thumbor should reject thumbnail requests that are the same size as the original or bigger as Declined.Jun 13 2017, 7:50 AM

• Gilles closed subtask T167490: Disable Thumbor dual-serving as Resolved.Jun 13 2017, 10:11 AM

• Gilles created subtask T167782: Deploy Thumbor to group0 wikis.

• Gilles created subtask T167783: Re-enable saving Thumbor thumbnails to Swift.Jun 13 2017, 10:13 AM

• Gilles closed subtask T167783: Re-enable saving Thumbor thumbnails to Swift as Resolved.Jun 13 2017, 10:32 AM

• Gilles created subtask T167793: Deploy Thumbor to group1 wikis.Jun 13 2017, 1:25 PM

• Gilles created subtask T167794: Deploy Thumbor to all wikipedias.

• Gilles created subtask T167795: Deploy Thumbor to Commons.

• Gilles created subtask T167796: Deploy Thumbor to all remaining wikis.

• Gilles closed subtask T167782: Deploy Thumbor to group0 wikis as Resolved.Jun 13 2017, 1:45 PM

• Gilles closed subtask T167793: Deploy Thumbor to group1 wikis as Resolved.

Change 358599 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] hieradata: use thumbor.svc for codfw too

https://gerrit.wikimedia.org/r/358599

gerritbot added a project: Patch-For-Review.Jun 13 2017, 1:51 PM

fgiunchedi created subtask T167801: Deploy thumbor in codfw.Jun 13 2017, 1:56 PM

Change 358599 merged by Filippo Giunchedi:
[operations/puppet@production] hieradata: use thumbor.svc for codfw too

https://gerrit.wikimedia.org/r/358599

I know you are not 100% done, but still: congratulations, Sirs! It's really impressive to see a long arc of design and implementation work and operational planning come to fruition. Kudos!

• Gilles moved this task from To-do: Goals prioritized current Quarter to Doing (old) on the Performance-Team board.Jun 14 2017, 7:36 PM

• Gilles updated the task description. (Show Details)Jun 19 2017, 1:39 PM

fgiunchedi created subtask T168297: Rename mw1236 / mw1237 to thumbor1003 / thumbor1004.Jun 19 2017, 1:51 PM

Change 360307 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] hieradata: have thumbor.svc alert critical

https://gerrit.wikimedia.org/r/360307

Change 360307 merged by Filippo Giunchedi:
[operations/puppet@production] hieradata: have thumbor.svc alert critical

https://gerrit.wikimedia.org/r/360307

Change 360309 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/puppet@production] Increase Swift timeout for Thumbor

https://gerrit.wikimedia.org/r/360309

• Gilles closed subtask T167794: Deploy Thumbor to all wikipedias as Resolved.Jun 20 2017, 9:29 AM

Change 360309 merged by Filippo Giunchedi:
[operations/puppet@production] Increase Swift timeout for Thumbor

https://gerrit.wikimedia.org/r/360309

Change 360350 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] thumbor: use jessie-backports as target release for python-thumbor-wikimedia

https://gerrit.wikimedia.org/r/360350

Change 360350 merged by Filippo Giunchedi:
[operations/puppet@production] thumbor: use jessie-backports as target release for python-thumbor-wikimedia

https://gerrit.wikimedia.org/r/360350

fgiunchedi closed subtask T167801: Deploy thumbor in codfw as Resolved.Jun 26 2017, 11:17 AM

• Gilles closed subtask T167795: Deploy Thumbor to Commons as Resolved.Jun 26 2017, 11:54 AM

• Gilles created subtask T168929: Identify source of gadget/extension pointing to thumb.php on imagescalers.Jun 27 2017, 9:10 AM

• Gilles closed subtask T167796: Deploy Thumbor to all remaining wikis as Resolved.Jun 27 2017, 9:22 AM

• Gilles removed a project: Patch-For-Review.Jun 27 2017, 4:32 PM

• Gilles added a subtask: T168949: Proper thumbnails of portrait photos not being generated; serious display issues.

• Gilles closed subtask T168949: Proper thumbnails of portrait photos not being generated; serious display issues as Resolved.Jun 29 2017, 8:02 AM

• Gilles reopened subtask T168949: Proper thumbnails of portrait photos not being generated; serious display issues as Open.Jun 29 2017, 8:49 AM

• Gilles changed the status of subtask T168949: Proper thumbnails of portrait photos not being generated; serious display issues from Open to Stalled.Jun 29 2017, 10:36 AM

fgiunchedi created subtask T169316: Thumbor should alert/page when thumbs aren't rendered.Jun 30 2017, 11:03 AM

• Cmjohnson closed subtask T168297: Rename mw1236 / mw1237 to thumbor1003 / thumbor1004 as Resolved.Jul 12 2017, 7:28 PM

Change 367373 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] thumbor: bump MemoryLimit to 15%

https://gerrit.wikimedia.org/r/367373

gerritbot added a project: Patch-For-Review.Jul 24 2017, 9:47 AM

Change 367373 merged by Filippo Giunchedi:
[operations/puppet@production] thumbor: bump MemoryLimit to 15%

https://gerrit.wikimedia.org/r/367373

fgiunchedi created subtask T171468: thumbor.svc intermittent timeout on pybal and icinga.Jul 24 2017, 1:04 PM

fgiunchedi closed subtask T171468: thumbor.svc intermittent timeout on pybal and icinga as Resolved.Jul 26 2017, 9:49 AM

• Prtksxna unsubscribed.Jul 26 2017, 9:59 AM

Krinkle removed a project: Patch-For-Review.Aug 3 2017, 3:59 AM

Thumbor has been serving all thumbnail traffic for over a month now. I think this task can be closed as the project is completed and successful. Subsequent bugfixes and improvements are tracked with the Thumbor project.

• Gilles changed the status of subtask T168949: Proper thumbnails of portrait photos not being generated; serious display issues from Stalled to Open.Aug 7 2017, 8:26 PM

• Gilles closed subtask T168949: Proper thumbnails of portrait photos not being generated; serious display issues as Resolved.Sep 4 2017, 1:09 PM

Change 377264 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] thumbor: use memorysize_mb fact for unit MemoryLimit

https://gerrit.wikimedia.org/r/377264

gerritbot added a project: Patch-For-Review.Sep 11 2017, 2:01 PM

Change 377264 merged by Filippo Giunchedi:
[operations/puppet@production] thumbor: use memorysize_mb fact for unit MemoryLimit

https://gerrit.wikimedia.org/r/377264

• Gilles closed subtask T144479: Ensure thumbor container access is preserved by mw filebackend setzoneaccess as Resolved.Sep 26 2017, 1:26 PM

• Gilles changed the status of subtask T168929: Identify source of gadget/extension pointing to thumb.php on imagescalers from Open to Stalled.Sep 27 2017, 8:01 AM

• Gilles closed subtask T168929: Identify source of gadget/extension pointing to thumb.php on imagescalers as Declined.Feb 13 2018, 10:11 AM