Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled, which causes errors.
Closed, ResolvedPublic1 Story Points

Description

Hi! Whenever I edit any page in VisualEditor, if I type "<ref>", Citoid opens (although there is no mention of it in the toolbar under "Cite". When I paste the web adress and press Generate, Citoid keeps "working on it", but nothing happens. When I open the console, I get a bunch of errors (log in attachment). Please fix!

Ivi104 created this task.Jun 29 2017, 1:40 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJun 29 2017, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mvolz added a subscriber: Mvolz.Jun 29 2017, 1:50 PM

Thanks for reporting this!

It looks like neither the Cite tool nor citoid are actually enabled on hr wiki, but for some reason typing <ref> opens the citoid dialog. This shouldn't happen.

@edsanders typing <ref> should probably open the basic reference dialog when citoid isn't enabled, correct?

Mvolz renamed this task from hr.wikipedia Citoid extension pending to Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab where citoid is not enabled. .Jun 29 2017, 1:52 PM
Mvolz renamed this task from Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab where citoid is not enabled. to Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled. .

Thanks for reporting this!

It looks like neither the Cite tool nor citoid are actually enabled on hr wiki, but for some reason typing <ref> opens the citoid dialog. This shouldn't happen.

@edsanders typing <ref> should probably open the basic reference dialog when citoid isn't enabled, correct?

Or maybe the automatic tab should just be removed/disabled?

Mvolz renamed this task from Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled. to Typing <ref> in VisualEditor opens the citoid dialog with the automatic tab even when citoid is not enabled, which causes errors..Jun 29 2017, 1:53 PM
Mvolz added a comment.Jun 29 2017, 1:57 PM

@lvi104 This is definitely a bug. In the meantime, you can click "manual" then "basic form" to get the basic reference form.

Alternatively, if you want to use the automatic feature you will have to enable citoid on your wiki. Here are the directions for that: https://www.mediawiki.org/wiki/Citoid/Enabling_Citoid_on_your_wiki

Mvolz moved this task from Backlog to Extension on the Citoid board.Jun 29 2017, 1:58 PM

It looks like neither the Cite tool nor citoid are actually enabled on hr wiki

Well Cite is installed otherwise you wouldn't have any references. Citoid is also installed, but not configured, so we need to only register the "<ref" -> Citoid sequence if Citoid is actually configured, not if it is just installed.

Change 362230 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Citoid@master] Disable 'auto' tab if type map isn't setup

https://gerrit.wikimedia.org/r/362230

Above patch reduces the dialog to a single tab:

Mvolz closed this task as Resolved.Jul 3 2017, 11:11 AM
Mvolz assigned this task to Esanders.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 3 2017, 11:11 AM

Change 362230 merged by jenkins-bot:
[mediawiki/extensions/Citoid@master] Disable 'auto' tab if type map isn't setup

https://gerrit.wikimedia.org/r/362230

Mvolz added a comment.Jul 3 2017, 11:14 AM

This be resolved in next deploy (Thurs) which will disable the automatic tab if citoid is not configured.

If your community would like the tab to be enabled and is having trouble do it you can also request help as part of this task: T127354

Jdforrester-WMF set the point value for this task to 1.Jul 3 2017, 9:12 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.