Page MenuHomePhabricator
Create Task
Maniphest T169389

[Regression pre-wmf.8] Table context menu is appearing over table cell menu
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
DLynch
Authored By
Ryasmeen
Jul 1 2017, 1:14 AM
Tags
Referenced Files
F9539702: image.png
Sep 14 2017, 8:16 PM
F9539707: image.png
Sep 14 2017, 8:16 PM
F8585807: Screen Shot 2017-06-30 at 6.09.53 PM.png
Jul 1 2017, 1:14 AM
Subscribers
Aklapper
• Deskana
DLynch
Esanders
gerritbot
Jdforrester-WMF
matmarex
View All 9 Subscribers

Description

Steps to reproduce:

  1. Insert a table
  2. Select a cell.
  3. Click on the cell operator arrow to open cell menu

Observe that the context menu for the table is appearing over the cell menu, which makes it impossible to do certain operation for some cells

Screen Shot 2017-06-30 at 6.09.53 PM.png (484×1 px, 93 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)mediawiki/extensions/VisualEditorwmf/1.30.0-wmf.18+1 -1
Update VE core submodule to master (05439f5b7)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)mediawiki/extensions/VisualEditormaster+1 -1
ui.TableLineContext: fix z-index for menuVisualEditor/VisualEditorwmf/1.30.0-wmf.18+4 -0
ui.TableLineContext: fix z-index for menuVisualEditor/VisualEditormaster+4 -0
Update VE core submodule to master (1934b77e7)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.TableLineContext: restore the z-index hackVisualEditor/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jul 1 2017, 1:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2017, 1:14 AM
• Deskana triaged this task as High priority.Jul 3 2017, 6:09 PM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Esanders added subscribers: matmarex, Esanders.Jul 6 2017, 1:55 PM

@matmarex was changing z-indices *points finger*

DLynch subscribed.Jul 6 2017, 3:04 PM

Yeah, bisect points to 73ce638f11.

gerritbot subscribed.Jul 6 2017, 3:08 PM

Change 363619 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: restore the z-index hack

https://gerrit.wikimedia.org/r/363619

gerritbot added a project: Patch-For-Review.Jul 6 2017, 3:08 PM
DLynch claimed this task.Jul 6 2017, 3:09 PM
gerritbot added a comment.Jul 6 2017, 7:29 PM

Change 363619 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.TableLineContext: restore the z-index hack

https://gerrit.wikimedia.org/r/363619

gerritbot added a comment.Jul 6 2017, 8:41 PM

Change 363691 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1934b77e7)

https://gerrit.wikimedia.org/r/363691

gerritbot added a comment.Jul 6 2017, 9:07 PM

Change 363691 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1934b77e7)

https://gerrit.wikimedia.org/r/363691

Jdforrester-WMF closed this task as Resolved.Jul 6 2017, 9:11 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF edited projects, added VisualEditor-Tables, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 6 2017, 9:11 PM
Ryasmeen added a project: Verified.Jul 7 2017, 12:16 AM
Ryasmeen added a project: Verified-in-Phase0.Jul 12 2017, 1:43 AM
Ryasmeen reopened this task as Open.Sep 14 2017, 7:46 PM
Ryasmeen added a comment.Sep 14 2017, 7:49 PM

Seems like this issue has resurfaced recently, seeing it in Beta/Test2/production. Happy to create a separate report on the same issue if that's more appropriate in this case.

DLynch added a comment.Sep 14 2017, 8:10 PM

One second. This is my fault from c1c38136d, but I was *sure* I'd tested this as well.

gerritbot added a comment.Sep 14 2017, 8:14 PM

Change 378099 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ui.TableLineContext: fix z-index for menu

https://gerrit.wikimedia.org/r/378099

gerritbot added a project: Patch-For-Review.Sep 14 2017, 8:14 PM
DLynch added a comment.Sep 14 2017, 8:16 PM

Okay, now we simultaneously have proper overlap:

image.png (271×240 px, 20 KB)

...and RTL arrows in correct positions:

image.png (254×373 px, 23 KB)

gerritbot added a comment.Sep 14 2017, 9:19 PM

Change 378099 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ui.TableLineContext: fix z-index for menu

https://gerrit.wikimedia.org/r/378099

gerritbot added a comment.Sep 14 2017, 9:23 PM

Change 378151 had a related patch set uploaded (by Jforrester; owner: DLynch):
[VisualEditor/VisualEditor@wmf/1.30.0-wmf.18] ui.TableLineContext: fix z-index for menu

https://gerrit.wikimedia.org/r/378151

gerritbot added a comment.Sep 14 2017, 9:25 PM

Change 378155 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (05439f5b7)

https://gerrit.wikimedia.org/r/378155

gerritbot added a comment.Sep 14 2017, 9:36 PM

Change 378151 merged by Jforrester:
[VisualEditor/VisualEditor@wmf/1.30.0-wmf.18] ui.TableLineContext: fix z-index for menu

https://gerrit.wikimedia.org/r/378151

gerritbot added a comment.Sep 14 2017, 9:38 PM

Change 378176 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)

https://gerrit.wikimedia.org/r/378176

gerritbot added a comment.Sep 14 2017, 9:40 PM

Change 378176 abandoned by Jforrester:
Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)

Reason:
Git review sucks

https://gerrit.wikimedia.org/r/378176

gerritbot added a comment.Sep 14 2017, 9:41 PM

Change 378181 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)

https://gerrit.wikimedia.org/r/378181

gerritbot added a comment.Sep 14 2017, 11:01 PM

Change 378155 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (05439f5b7)

https://gerrit.wikimedia.org/r/378155

gerritbot added a comment.Sep 14 2017, 11:27 PM

Change 378181 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] Update VE core submodule to wmf/1.30.0-wmf.18 HEAD (0222046b2)

https://gerrit.wikimedia.org/r/378181

Stashbot subscribed.Sep 14 2017, 11:34 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-14T23:34:23Z] <catrope@tin> Synchronized php-1.30.0-wmf.18/extensions/VisualEditor/lib/ve/src/ui/styles/ve.ui.TableLineContext.css: T169389 (duration: 00m 45s)

Jdforrester-WMF closed this task as Resolved.Sep 14 2017, 11:40 PM

Re-fix now deployed.

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Sep 15 2017, 12:01 AM
Ryasmeen added a comment.Sep 15 2017, 6:55 PM

Tested and re-verified.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL