Error after cancelling switch between edit modes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

For a normal wikitext editor (Without the beta setting of a new editor)

Start editing an article in the visual editor
Click to switch to wiki mode
In the confirmation window, click cancel

The confirmation window disappears, VE remains inactive
Console:

VM421:312 Uncaught TypeError: Cannot read property 'reject' of undefined
    at VeUiMWWikitextSwitchConfirmDialog.eval (eval at <anonymous> (load.php?debug=false&lang=ru&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:4), <anonymous>:312:755)
    at eval (eval at <anonymous> (load.php?debug=false&lang=ru&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:4), <anonymous>:29:113)
    at OO.ui.Process.execute (eval at <anonymous> (load.php?debug=false&lang=ru&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:4), <anonymous>:29:760)
    at VeUiMWWikitextSwitchConfirmDialog.OO.ui.Window.teardown (eval at <anonymous> (load.php?debug=false&lang=ru&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:4), <anonymous>:47:681)
    at eval (eval at <anonymous> (load.php?debug=false&lang=ru&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0r0nkm9:4), <anonymous>:37:876)

Details

	Subject	Repo	Branch	Lines +/-
	ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack"	mediawiki/extensions/VisualEditor	master	+0 -16

Customize query in gerrit

Related Objects

Mentioned Here: rEVED237d68f6dbdd: Offer to retain changes when switching to the wikitext editor
rGOJUac10e40b6b4a: WindowManager: Add WindowInstance - a Promise-based lifecycle object

Event Timeline

Sunpriat created this task.Jul 3 2017, 10:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2017, 10:56 PM

Jack_who_built_the_house subscribed.Jul 4 2017, 7:17 AM

This is happening in production and could cause data loss.

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJul 4 2017, 6:01 PM

Well…

ve.ui.MWWikitextSwitchConfirmDialog.prototype.getTeardownProcess = function ( data ) {
	data = data || {};
	return ve.ui.MWWikitextSwitchConfirmDialog.super.prototype.getTeardownProcess.call( this, data )
		.first( function () {
			// EVIL HACK - we shouldn't be reaching into the manager for these promises
			if ( data.action === 'switch' ) {
				this.manager.closing.resolve( data );
			} else {
				this.manager.closing.reject( data );
			}
		}, this );
};

Looks like the evil hack broke.

It was probably broken by rGOJUac10e40b6b4a: WindowManager: Add WindowInstance - a Promise-based lifecycle object in OOjs UI, which removed this undocumented private property that we relied on.

I'm not sure if this was actually doing anything, before it broke. In the original version of the "switch to wikitext" functionality (rEVED237d68f6dbdd: Offer to retain changes when switching to the wikitext editor), it appears that this was used to pass the 'data' from 'getTeardownProcess' to outside of the dialog instance, to the Target. But this code works differently these days (the dialog calls Target#switchToWikitextEditor itself), so these might not be necessary at all?

Change 363231 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack"

https://gerrit.wikimedia.org/r/363231

gerritbot added a project: Patch-For-Review.Jul 4 2017, 7:49 PM

Change 363231 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWWikitextSwitchConfirmDialog: Remove broken "evil hack"

https://gerrit.wikimedia.org/r/363231

Jdforrester-WMF renamed this task from Error after canceling switch to Error after cancelling switch between edit modes.Jul 6 2017, 7:11 PM

Jdforrester-WMF closed this task as Resolved.

Jdforrester-WMF assigned this task to matmarex.

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.

Jdforrester-WMF set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 6 2017, 7:11 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 4:01 AM

Ryasmeen added a project: Verified.Jul 10 2017, 11:04 PM

Ryasmeen added a project: Verified-in-Phase0.Jul 12 2017, 1:38 AM

Error after cancelling switch between edit modesClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Error after cancelling switch between edit modes
Closed, ResolvedPublic1 Estimated Story Points
Actions