Syntax highlighting has occasional toolbar errors
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• DannyH
	Jul 6 2017, 11:20 PM

Description

I've been testing syntax highlighting on test.wiki for a couple hours. Twice so far, I've opened the edit window to find that the toolbar isn't there and syntax highlighting doesn't work.

The first time, I logged out and tried a new browser, and at some point the problem went away. I don't know what actually fixed it.

Attached is the error messages I'm getting:

Details

	Subject	Repo	Branch	Lines +/-
	Make sure enhanced editing toolbar is loaded before adding button	mediawiki/extensions/CodeMirror	master	+10 -5

Customize query in gerrit

Related Objects

Mentioned In: T170056: Exception in module-execute in module ext.CodeMirror

Event Timeline

• DannyH created this task.Jul 6 2017, 11:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2017, 11:20 PM

Looks like this is failing at line 272 in ext.CodeMirror.js. Might need to be inside a mw.loader.using( 'ext.wikiEditor.toolbar'....

kaldari triaged this task as High priority.Jul 10 2017, 8:51 PM

kaldari set the point value for this task to 1.Jul 10 2017, 8:54 PM

Change 364324 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/CodeMirror@master] Make sure enhanced editing toolbar is loaded before adding button

https://gerrit.wikimedia.org/r/364324

gerritbot added a project: Patch-For-Review.Jul 10 2017, 9:17 PM

Change 364324 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Make sure enhanced editing toolbar is loaded before adding button

https://gerrit.wikimedia.org/r/364324

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 10 2017, 10:00 PM

MaxSem closed this task as Resolved.Jul 10 2017, 10:34 PM

MaxSem assigned this task to kaldari.

MaxSem removed a project: Patch-For-Review.

kaldari moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.Jul 11 2017, 4:44 PM

• Niharika mentioned this in T170056: Exception in module-execute in module ext.CodeMirror.Jul 12 2017, 8:18 PM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 18 2017, 10:40 PM

• DannyH moved this task from New & TBD Tickets to Archive on the Community-Tech board.Jul 18 2017, 10:44 PM