Page MenuHomePhabricator

Reference diffs not working correctly on historical diffs
Closed, ResolvedPublic8 Story Points

Description

The following simple test case throws an exception, trying to access the internal item with index 2:

Event Timeline

Esanders created this task.Jul 11 2017, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2017, 1:37 PM

The current version of the visual diff makes a lot of assumptions about the internal list being append-only, i.e. that document B's internalList is a superset of document A, however if parse the documents separately from the server that is not the case.

Deskana triaged this task as Normal priority.Jul 11 2017, 7:18 PM
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

I also imagine this is quite a lot of work.

Change 371128 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (81a4760ea)

https://gerrit.wikimedia.org/r/371128

Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 8.

Change 371128 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (81a4760ea)

https://gerrit.wikimedia.org/r/371128

Deskana closed this task as Resolved.Aug 13 2017, 9:24 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 13 2017, 9:24 PM