Page MenuHomePhabricator

[betalabs-regression] Monobook does not display Namespace filter icon
Closed, ResolvedPublic

Description

1.In betalabs go RC page - Namespace and Tags filter icons will be displayed.

  1. Change the skin to monobook - RC page will be displayed without Namespace icon.

Note: The place is "reserved" for the Namespace icon - if clicked, the Namespace filter drop-down is displayed.

Screen Shot 2017-07-11 at 1.18.22 PM.png (319×1 px, 50 KB)

Screen Shot 2017-07-11 at 1.20.22 PM.png (400×1 px, 69 KB)

Event Timeline

Change 364599 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] Add 'article' icon to Apex

https://gerrit.wikimedia.org/r/364599

Change 364603 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Add 'article' icon manually until it is available in Apex

https://gerrit.wikimedia.org/r/364603

Change 364603 abandoned by Mooeypoo:
RCFilters: Add 'article' icon manually until it is available in Apex

Reason:
Nevermind, the upstream fix got in to the new release!

https://gerrit.wikimedia.org/r/364603

Abandoned the RCFilter-specific fix since this got into the OOUI release today. Should be available on Beta later today.

Change 364599 merged by jenkins-bot:
[oojs/ui@master] Apex theme: Add 'article' icon, copied from WikimediaUI

https://gerrit.wikimedia.org/r/364599

Hmm, even if the icon is missing from one of the themes, ResourceLoaderOOUIImageModule should still automatically use the default theme as a fallback.

Checked in betalabs - fixed:

Screen Shot 2017-07-11 at 4.16.50 PM.png (246×1 px, 39 KB)

QA Recommendation: Resolve

Hmm, even if the icon is missing from one of the themes, ResourceLoaderOOUIImageModule should still automatically use the default theme as a fallback.

Actually this isn't true, and never was, my mistake. It only does fallbacks to the default theme when the whole icon pack is missing, not when an icon pack exists but some icons in it are missing.