[bug] Logout icon doesn't render the correct size
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Nirzar
	Jul 11 2017, 11:51 PM

Description

Bug -

The logout icon (power off) is smaller than the rest of the icons.

The SVG is correct. there is some bug in the code.

Developer notes

Our icons are based on font-size. The font-size of all menu items is 0.875em.
To fix this, the mw-ui-icon element needs to be set to font-size 16px;

Details

	Subject	Repo	Branch	Lines +/-
	Logout icon should not be small	mediawiki/skins/MinervaNeue	master	+2 -0

Customize query in gerrit

Related Objects

Mentioned In: T72961: Main menu SVG icons should be 24 by 24 px to support IE8
Mentioned Here: T72961: Main menu SVG icons should be 24 by 24 px to support IE8

Event Timeline

• Nirzar created this task.Jul 11 2017, 11:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2017, 11:51 PM

• Nirzar triaged this task as Low priority.Jul 11 2017, 11:51 PM

• Nirzar moved this task from Backlog to Visual Design Improvements on the Design (RW-Design-Debt) board.

• Nirzar moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 11 2017, 11:53 PM

Jdlrobson closed this task as a duplicate of T72961: Main menu SVG icons should be 24 by 24 px to support IE8.Jul 12 2017, 12:01 AM

Jdlrobson mentioned this in T72961: Main menu SVG icons should be 24 by 24 px to support IE8.

per chat with the team, reopening this as a separate issue that persists on production.

cc @Volker_E maybe find a fix?

Let's work out root cause. Apparently this was not related to T72961 and was already a problem.

Jdlrobson raised the priority of this task from Low to Medium.Aug 17 2017, 2:59 PM

Jdlrobson added a project: good first task.

Jdlrobson updated the task description. (Show Details)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 17 2017, 2:59 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Aug 17 2017, 2:59 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Aug 22 2017, 4:19 PM

pmiazga removed a project: good first task.Aug 22 2017, 4:43 PM

• Niedzielski set the point value for this task to 2.Aug 22 2017, 4:48 PM

Change 374333 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Logout icon should not be small

https://gerrit.wikimedia.org/r/374333

gerritbot added a project: Patch-For-Review.Aug 28 2017, 2:56 PM

Change 374333 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Logout icon should not be small

https://gerrit.wikimedia.org/r/374333

Over to you

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 28 2017, 6:00 PM

where can i test it?

Macro votecat: looks good

MBinder_WMF moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.Oct 10 2017, 7:27 PM

[bug] Logout icon doesn't render the correct sizeClosed, ResolvedPublic2 Estimated Story PointsActions